Handle bad data in analysis server integration tests.

pkg/analysis_server/test/integration/integration_tests.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.integration.analysis;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:convert';
 import 'dart:io';
@@ skipping 453 matching lines @@
    * up until the test finishes, so that they can be examined in the debugger
    * or printed out in response to a call to [debugStdio].
    */
   final List<String> _recordedStdio = <String>[];
 
   /**
    * True if we are currently printing out messages exchanged with the server.
    */
   bool _debuggingStdio = false;
 
+  /**
+   * True if we've received bad data from the server, and we are aborting the
+   * test.
+   */
+  bool _receivedBadDataFromServer = false;
+
   Server._(this._process);
 
   /**
    * Get a stream which will receive notifications of the given event type.
    * The values delivered to the stream will be the contents of the 'params'
    * field of the notification message.
    */
   Stream onNotification(String event) {
     Stream notificationStream = _notificationStreams[event];
     if (notificationStream == null) {
@@ skipping 33 matching lines @@
       arguments.add('--debug');
     }
     arguments.add('--package-root=$packageRoot');
     arguments.add(serverPath);
     return Process.start(dartBinary, arguments).then((Process process) {
       Server server = new Server._(process);
       process.stdout.transform((new Utf8Codec()).decoder).transform(
           new LineSplitter()).listen((String line) {
         String trimmedLine = line.trim();
         server._recordStdio('RECV: $trimmedLine');
-        var message = JSON.decoder.convert(trimmedLine);
+        var message;
+        try {
+          message = JSON.decoder.convert(trimmedLine);
+        } catch (exception) {
+          server._badDataFromServer();
+          return;
+        }
         expect(message, isMap);
         Map messageAsMap = message;
         if (messageAsMap.containsKey('id')) {
           expect(messageAsMap['id'], isString);
           String id = message['id'];
           Completer completer = server._pendingCommands[id];
           if (completer == null) {
             fail('Unexpected response from server: id=$id');
           } else {
             server._pendingCommands.remove(id);
@@ skipping 19 matching lines @@
               server._notificationControllers[event];
           if (notificationController != null) {
             notificationController.add(messageAsMap['params']);
           }
           // Check that the message is well-formed.  We do this after calling
           // notificationController.add() so that we don't stall the test in the
           // event of an error.
           expect(message, isNotification);
         }
       });
-      process.stderr.listen((List<int> data) {
-        fail('Unexpected output from stderr');
+      process.stderr.transform((new Utf8Codec()).decoder).transform(
+          new LineSplitter()).listen((String line) {
+        String trimmedLine = line.trim();
+        server._recordStdio('ERR:  $trimmedLine');
+        server._badDataFromServer();
       });
       return server;
     });
   }
 
   /**
    * Stop the server.
    */
   Future kill() {
     _process.kill();
@@ skipping 33 matching lines @@
     if (_debuggingStdio) {
       return;
     }
     _debuggingStdio = true;
     for (String line in _recordedStdio) {
       print(line);
     }
   }
 
   /**
+   * Deal with bad data received from the server.
+   */
+  void _badDataFromServer() {
+    if (_receivedBadDataFromServer) {
+      // We're already dealing with it.
+      return;
+    }
+    _receivedBadDataFromServer = true;
+    debugStdio();
+    // Give the server 1 second to continue outputting bad data before we kill
+    // the test.  This is helpful if the server has had an unhandled exception
+    // and is outputting a stacktrace, because it ensures that we see the
+    // entire stacktrace.  Use expectAsync() to prevent the test from
+    // ending during this 1 second.
+    new Future.delayed(new Duration(seconds: 1), expectAsync(() {
+      fail('Bad data received from server');
+    }));
+  }
+
+  /**
    * Record a message that was exchanged with the server, and print it out if
    * [debugStdio] has been called.
    */
   void _recordStdio(String line) {
     if (_debuggingStdio) {
       print(line);
     }
     _recordedStdio.add(line);
   }
 }