Issue 414303004: Add build configuration variable 'c_frame_pointers' to control whether or not frame pointers are in…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 414303004: Add build configuration variable 'c_frame_pointers' to control whether or not frame pointers are in… (Closed)

Created:
6 years, 5 months ago by Cutch

Modified:
6 years, 4 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add build configuration variable 'c_frame_pointers' to control whether or not frame pointers are included and which stack walker the profiler uses. BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -25 lines)			Patch
M	runtime/vm/profiler.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	tools/gyp/all.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/gyp/configurations_android.gypi	View		2 chunks	+20 lines, -3 lines	0 comments	Download
M	tools/gyp/configurations_make.gypi	View		1 chunk	+26 lines, -12 lines	0 comments	Download
M	tools/gyp/configurations_msvs.gypi	View	1 2 3	4 chunks	+24 lines, -6 lines	0 comments	Download
M	tools/gyp/configurations_xcode.gypi	View	1 2 3	2 chunks	+20 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM, but please figure out how to also stop omitting frame pointers on Xcode builds. ...

6 years, 4 months ago (2014-07-29 20:06:23 UTC) #2

Cutch

6 years, 4 months ago (2014-07-29 23:01:08 UTC) #3

This was committed in https://code.google.com/p/dart/source/detail?r=38711

Expand Messages | Collapse Messages