Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: tools/gyp/configurations_xcode.gypi

Issue 414303004: Add build configuration variable 'c_frame_pointers' to control whether or not frame pointers are in… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gyp/configurations_msvs.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gyp/configurations_xcode.gypi
diff --git a/tools/gyp/configurations_xcode.gypi b/tools/gyp/configurations_xcode.gypi
index 91524a5cbd9ed2568010b87487ab9301891459b1..f5ba5c0d539046fb6dd30951608622a190fd543b 100644
--- a/tools/gyp/configurations_xcode.gypi
+++ b/tools/gyp/configurations_xcode.gypi
@@ -29,10 +29,6 @@
'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES', # -fvisibility-inlines-hidden
'GCC_WARN_NON_VIRTUAL_DESTRUCTOR': 'YES', # -Wnon-virtual-dtor
'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror
- 'OTHER_CFLAGS': [ # Disable frame pointers by default.
- '-fomit-frame-pointer',
- '-momit-leaf-frame-pointer',
- ],
'WARNING_CFLAGS': [
'<@(common_gcc_warning_flags)',
'-Wtrigraphs', # Disable Xcode default.
@@ -58,6 +54,26 @@
'GCC_ENABLE_TRIGRAPHS': 'NO',
'COMBINE_HIDPI_IMAGES': 'YES',
},
+ 'conditions': [
+ ['c_frame_pointers==1', {
+ 'xcode_settings': {
+ 'OTHER_CFLAGS': [
+ '-fno-omit-frame-pointer',
+ '-mno-omit-leaf-frame-pointer',
+ ],
+ },
+ 'defines': [
+ 'PROFILE_NATIVE_CODE',
+ ],
+ }, {
+ 'xcode_settings': {
+ 'OTHER_CFLAGS': [
+ '-fomit-frame-pointer',
+ '-momit-leaf-frame-pointer',
+ ],
+ },
+ }],
+ ],
},
'Dart_Macos_ia32_Base': {
'abstract': 1,
« no previous file with comments | « tools/gyp/configurations_msvs.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698