Issue 412913002: Put reflective tests in a group whose name matches the class name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 412913002: Put reflective tests in a group whose name matches the class name. (Closed)

Created:
6 years, 5 months ago by Paul Berry

Modified:
6 years, 5 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Put reflective tests in a group whose name matches the class name. This makes it easier to locate the code associated with a failing test. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38514

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -21 lines)			Patch
	M	pkg/analysis_testing/lib/reflective_tests.dart	View		1 chunk	+24 lines, -21 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

LGTM Although now we have to go through all the places where this function is ...

6 years, 5 months ago (2014-07-23 17:11:22 UTC) #2

Paul Berry

6 years, 5 months ago (2014-07-23 17:17:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r38514 (presubmit successful).