Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: pkg/analysis_testing/lib/reflective_tests.dart

Issue 412913002: Put reflective tests in a group whose name matches the class name. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_testing/lib/reflective_tests.dart
diff --git a/pkg/analysis_testing/lib/reflective_tests.dart b/pkg/analysis_testing/lib/reflective_tests.dart
index 2c737f7910d74df36c85d58208c30837eccd80af..202a0be0532853fc00876f8b2845bc2da3b792db 100644
--- a/pkg/analysis_testing/lib/reflective_tests.dart
+++ b/pkg/analysis_testing/lib/reflective_tests.dart
@@ -39,27 +39,30 @@ class ReflectiveTestCase {
*/
void runReflectiveTests(Type type) {
ClassMirror classMirror = reflectClass(type);
- classMirror.instanceMembers.forEach((symbol, memberMirror) {
- // we need only methods
- if (memberMirror is! MethodMirror || !memberMirror.isRegularMethod) {
- return;
- }
- String memberName = MirrorSystem.getName(symbol);
- // test_
- if (memberName.startsWith('test_')) {
- String testName = memberName.substring('test_'.length);
- test(testName, () {
- return _runTest(classMirror, symbol);
- });
- return;
- }
- // solo_test_
- if (memberName.startsWith('solo_test_')) {
- String testName = memberName.substring('solo_test_'.length);
- solo_test(testName, () {
- return _runTest(classMirror, symbol);
- });
- }
+ String className = MirrorSystem.getName(classMirror.simpleName);
+ group(className, () {
+ classMirror.instanceMembers.forEach((symbol, memberMirror) {
+ // we need only methods
+ if (memberMirror is! MethodMirror || !memberMirror.isRegularMethod) {
+ return;
+ }
+ String memberName = MirrorSystem.getName(symbol);
+ // test_
+ if (memberName.startsWith('test_')) {
+ String testName = memberName.substring('test_'.length);
+ test(testName, () {
+ return _runTest(classMirror, symbol);
+ });
+ return;
+ }
+ // solo_test_
+ if (memberName.startsWith('solo_test_')) {
+ String testName = memberName.substring('solo_test_'.length);
+ solo_test(testName, () {
+ return _runTest(classMirror, symbol);
+ });
+ }
+ });
});
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698