Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 407833002: more progress implementing analysis server code completion (Closed)

Created:
6 years, 5 months ago by danrubel
Modified:
6 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

more progress implementing analysis server code completion - add more properties returned by completion suggestion - move completion suggestion into services - move property constants into services for use by completion services - move HasToJson into services for completion - remove duplicate completion test BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38418

Patch Set 1 #

Total comments: 4

Patch Set 2 : merge and address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, -297 lines) Patch
M pkg/analysis_server/lib/src/collections.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_highlights.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_hover.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_navigation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_occurrences.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_outline.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_overrides.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/element.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/constants.dart View 2 chunks +1 line, -64 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_completion.dart View 2 chunks +14 lines, -22 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_edit.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_server.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/search/search_domain.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/search/search_result.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_hover_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_notification_highlights_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_notification_navigation_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_notification_occurrences_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_notification_outline_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_notification_overrides_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/completion_test.dart View 3 chunks +15 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/computer/element_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
D pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
M pkg/analysis_server/test/domain_edit_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/operation/operation_analysis_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/abstract_search_domain.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/search/member_declarations_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/search/member_references_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/search/search_domain_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/search/search_result_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/top_level_declarations_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download
A pkg/analysis_services/lib/completion/completion_suggestion.dart View 1 1 chunk +187 lines, -0 lines 0 comments Download
A pkg/analysis_services/lib/constants.dart View 1 1 chunk +72 lines, -0 lines 0 comments Download
A + pkg/analysis_services/lib/json.dart View 1 chunk +1 line, -15 lines 0 comments Download
M pkg/analysis_services/lib/src/generated/completion.dart View 30 chunks +50 lines, -115 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danrubel
6 years, 5 months ago (2014-07-20 15:04:04 UTC) #1
scheglov
LGTM https://codereview.chromium.org/407833002/diff/1/pkg/analysis_services/lib/completion/completion_suggestion.dart File pkg/analysis_services/lib/completion/completion_suggestion.dart (right): https://codereview.chromium.org/407833002/diff/1/pkg/analysis_services/lib/completion/completion_suggestion.dart#newcode9 pkg/analysis_services/lib/completion/completion_suggestion.dart:9: import '../constants.dart'; Use package Uri? https://codereview.chromium.org/407833002/diff/1/pkg/analysis_services/lib/constants.dart File pkg/analysis_services/lib/constants.dart ...
6 years, 5 months ago (2014-07-20 19:09:56 UTC) #2
danrubel
Committed patchset #2 manually as r38418 (presubmit successful).
6 years, 5 months ago (2014-07-21 02:05:09 UTC) #3
danrubel
6 years, 5 months ago (2014-07-21 12:54:14 UTC) #4
Message was sent while issue was closed. 
Good suggestions. Thanks!

https://codereview.chromium.org/407833002/diff/1/pkg/analysis_services/lib/co...
File pkg/analysis_services/lib/completion/completion_suggestion.dart (right):

https://codereview.chromium.org/407833002/diff/1/pkg/analysis_services/lib/co...
pkg/analysis_services/lib/completion/completion_suggestion.dart:9: import
'../constants.dart';
On 2014/07/20 19:09:55, scheglov wrote:
> Use package Uri?

Done.

https://codereview.chromium.org/407833002/diff/1/pkg/analysis_services/lib/co...
File pkg/analysis_services/lib/constants.dart (right):

https://codereview.chromium.org/407833002/diff/1/pkg/analysis_services/lib/co...
pkg/analysis_services/lib/constants.dart:5: library service.constants;
On 2014/07/20 19:09:56, scheglov wrote:
> "services." ?

Done.

Powered by Google App Engine
This is Rietveld 408576698