Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: pkg/analysis_server/test/completion_test.dart

Issue 407833002: more progress implementing analysis server code completion (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge and address comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/completion_test.dart
diff --git a/pkg/analysis_server/test/completion_test.dart b/pkg/analysis_server/test/completion_test.dart
index f43b9d55ed8183bc2ed7fbd65ce9ccdd622145c3..a78605c59df78a6605a903abd7c25f070484021c 100644
--- a/pkg/analysis_server/test/completion_test.dart
+++ b/pkg/analysis_server/test/completion_test.dart
@@ -9,6 +9,8 @@ import 'dart:async';
import 'package:analysis_server/src/constants.dart';
import 'package:analysis_server/src/domain_completion.dart';
import 'package:analysis_server/src/protocol.dart';
+import 'package:analysis_services/completion/completion_suggestion.dart';
+import 'package:analysis_services/constants.dart';
import 'package:analysis_services/index/index.dart' show Index;
import 'package:analysis_services/index/local_memory_index.dart';
import 'package:analysis_testing/reflective_tests.dart';
@@ -39,11 +41,19 @@ class CompletionTest extends AbstractAnalysisTest {
+ content.substring(completionOffset + 1));
}
- void assertHasResult(String completion) {
+ void assertHasResult(CompletionSuggestionKind kind,
+ CompletionRelevance relevance, String completion,
+ bool isDeprecated, bool isPotential) {
var cs = suggestions.firstWhere((cs) => cs.completion == completion, orElse: () {
var completions = suggestions.map((s) => s.completion).toList();
fail('expected "$completion" but found\n $completions');
});
+ expect(cs.kind, equals(kind));
+ expect(cs.relevance, equals(relevance));
+ expect(cs.selectionOffset, equals(completion.length));
+ expect(cs.selectionLength, equals(0));
+ expect(cs.isDeprecated, equals(isDeprecated));
+ expect(cs.isPotential, equals(isPotential));
}
void assertValidId(String id) {
@@ -104,8 +114,10 @@ class CompletionTest extends AbstractAnalysisTest {
main() {^}
''');
return getSuggestions().then((_) {
- assertHasResult('Object');
- assertHasResult('HtmlElement');
+ assertHasResult(CompletionSuggestionKind.CLASS,
+ CompletionRelevance.DEFAULT, 'Object', false, false);
+ assertHasResult(CompletionSuggestionKind.CLASS,
+ CompletionRelevance.DEFAULT, 'HtmlElement', false, false);
});
}
}

Powered by Google App Engine
This is Rietveld 408576698