Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Issue 402493002: Remove 'errorCode' field from AnalysisError in the analysis server API. (Closed)

Created:
6 years, 5 months ago by Paul Berry
Modified:
6 years, 5 months ago
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Remove 'errorCode' field from AnalysisError in the analysis server API. R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -101 lines) Patch
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/constants.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_edit.dart View 3 chunks +9 lines, -74 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/operation/operation_analysis_test.dart View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paul Berry
6 years, 5 months ago (2014-07-17 00:05:27 UTC) #1
Brian Wilkerson
LGTM
6 years, 5 months ago (2014-07-17 00:22:17 UTC) #2
scheglov
LGTM
6 years, 5 months ago (2014-07-17 00:43:22 UTC) #3
Paul Berry
6 years, 5 months ago (2014-07-17 15:05:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r38331 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698