Remove 'errorCode' field from AnalysisError in the analysis server API.

pkg/analysis_server/test/domain_analysis_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.domain.analysis;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/computer/element.dart';
 import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_server/src/domain_analysis.dart';
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_testing/mock_sdk.dart';
 import 'package:analysis_testing/reflective_tests.dart';
 import 'package:analyzer/file_system/memory_file_system.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:path/path.dart';
 import 'package:unittest/unittest.dart';
 
 import 'analysis_abstract.dart';
 import 'mocks.dart';
 
 
 AnalysisError jsonToAnalysisError(Map<String, Object> json) {
   Map<String, Object> jsonLocation = json[LOCATION];
   Location location = new Location(jsonLocation[FILE], _getSafeInt(jsonLocation,
       OFFSET, -1), _getSafeInt(jsonLocation, LENGTH, -1), _getSafeInt(jsonLocation,
       START_LINE, -1), _getSafeInt(jsonLocation, START_COLUMN, -1));
-  return new AnalysisError(json[ERROR_CODE], json[SEVERITY], json[TYPE], location,
+  return new AnalysisError('unknown error code', json[SEVERITY], json[TYPE], location,
       json['message'], json['correction']);
 }
 
 
 main() {
   groupSep = ' | ';
 
   runReflectiveTests(AnalysisDomainTest);
 
   MockServerChannel serverChannel;
@@ skipping 127 matching lines @@
 }
 
 
 testNotificationErrors() {
   AnalysisTestHelper helper;
 
   setUp(() {
     helper = new AnalysisTestHelper();
   });
 
-  test('ParserErrorCode', () {
+  test('ParserError', () {
     helper.createSingleFileProject('library lib');
     return helper.waitForOperationsFinished().then((_) {
       List<AnalysisError> errors = helper.getTestErrors();
       expect(errors, hasLength(1));
       AnalysisError error = errors[0];
       expect(error.location.file, '/project/bin/test.dart');
       expect(error.location.offset, isPositive);
       expect(error.location.length, isNonNegative);
-      expect(error.errorCode, 'ParserErrorCode.EXPECTED_TOKEN');
       expect(error.severity, 'ERROR');
       expect(error.type, 'SYNTACTIC_ERROR');
       expect(error.message, isNotNull);
     });
   });
 
-  test('StaticWarningCode', () {
+  test('StaticWarning', () {
     helper.createSingleFileProject(['main() {', '  print(unknown);', '}']);
     return helper.waitForOperationsFinished().then((_) {
       List<AnalysisError> errors = helper.getTestErrors();
       expect(errors, hasLength(1));
       AnalysisError error = errors[0];
-      expect(error.errorCode, 'StaticWarningCode.UNDEFINED_IDENTIFIER');
+      expect(error.severity, 'WARNING');
+      expect(error.type, 'STATIC_WARNING');
     });
   });
 }
 
 
 testUpdateContent() {
   test('full content', () {
     AnalysisTestHelper helper = new AnalysisTestHelper();
     helper.createSingleFileProject('// empty');
     return helper.waitForOperationsFinished().then((_) {
@@ skipping 432 matching lines @@
     return waitForServerOperationsPerformed(server);
   }
 
   static String _getCodeString(code) {
     if (code is List<String>) {
       code = code.join('\n');
     }
     return code as String;
   }
 }