Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 399963004: Move pub/barback's Pool class into its own package. (Closed)

Created:
6 years, 5 months ago by nweiz
Modified:
6 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move pub/barback's Pool class into its own package. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=38525

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -292 lines) Patch
M pkg/barback/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/barback/lib/src/utils/file_pool.dart View 1 chunk +1 line, -1 line 3 comments Download
D pkg/barback/lib/src/utils/pool.dart View 1 chunk +0 lines, -141 lines 0 comments Download
M pkg/barback/pubspec.yaml View 2 chunks +2 lines, -1 line 0 comments Download
A + pkg/pool/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A pkg/pool/README.md View 1 chunk +53 lines, -0 lines 2 comments Download
A + pkg/pool/lib/pool.dart View 3 chunks +5 lines, -7 lines 0 comments Download
A pkg/pool/pubspec.yaml View 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/pool/test/pool_test.dart View 1 chunk +137 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart View 2 chunks +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/io.dart View 2 chunks +1 line, -1 line 0 comments Download
D sdk/lib/_internal/pub/lib/src/pool.dart View 1 chunk +0 lines, -141 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
6 years, 5 months ago (2014-07-17 21:46:02 UTC) #1
Bob Nystrom
https://codereview.chromium.org/399963004/diff/1/pkg/barback/lib/src/utils/file_pool.dart File pkg/barback/lib/src/utils/file_pool.dart (right): https://codereview.chromium.org/399963004/diff/1/pkg/barback/lib/src/utils/file_pool.dart#newcode11 pkg/barback/lib/src/utils/file_pool.dart:11: import 'package:pool/pool.dart'; How about giving this a bit more ...
6 years, 5 months ago (2014-07-17 22:09:14 UTC) #2
nweiz
https://codereview.chromium.org/399963004/diff/1/pkg/barback/lib/src/utils/file_pool.dart File pkg/barback/lib/src/utils/file_pool.dart (right): https://codereview.chromium.org/399963004/diff/1/pkg/barback/lib/src/utils/file_pool.dart#newcode11 pkg/barback/lib/src/utils/file_pool.dart:11: import 'package:pool/pool.dart'; On 2014/07/17 22:09:14, Bob Nystrom wrote: > ...
6 years, 5 months ago (2014-07-17 22:56:55 UTC) #3
Bob Nystrom
lgtm https://codereview.chromium.org/399963004/diff/1/pkg/barback/lib/src/utils/file_pool.dart File pkg/barback/lib/src/utils/file_pool.dart (right): https://codereview.chromium.org/399963004/diff/1/pkg/barback/lib/src/utils/file_pool.dart#newcode11 pkg/barback/lib/src/utils/file_pool.dart:11: import 'package:pool/pool.dart'; On 2014/07/17 22:56:55, nweiz wrote: > ...
6 years, 5 months ago (2014-07-21 17:47:36 UTC) #4
nweiz
6 years, 5 months ago (2014-07-23 23:32:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r38525 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698