Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 397693002: Allow updating the `targetUrl` property of SingleMapping. (Closed)

Created:
6 years, 5 months ago by tjblasi
Modified:
6 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow updating the `targetUrl` property of SingleMapping. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=38245

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removing unnecessary '= null' per review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M pkg/source_maps/lib/parser.dart View 1 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tjblasi
It seems like if we can update other pieces of the SingleMapping `targetUrl` should be ...
6 years, 5 months ago (2014-07-15 17:53:14 UTC) #1
Siggi Cherem (dart-lang)
good point :) lgtm https://codereview.chromium.org/397693002/diff/1/pkg/source_maps/lib/parser.dart File pkg/source_maps/lib/parser.dart (right): https://codereview.chromium.org/397693002/diff/1/pkg/source_maps/lib/parser.dart#newcode152 pkg/source_maps/lib/parser.dart:152: String sourceRoot = null; just ...
6 years, 5 months ago (2014-07-15 17:54:56 UTC) #2
tjblasi
Thanks! https://codereview.chromium.org/397693002/diff/1/pkg/source_maps/lib/parser.dart File pkg/source_maps/lib/parser.dart (right): https://codereview.chromium.org/397693002/diff/1/pkg/source_maps/lib/parser.dart#newcode152 pkg/source_maps/lib/parser.dart:152: String sourceRoot = null; On 2014/07/15 17:54:56, Siggi ...
6 years, 5 months ago (2014-07-15 18:00:14 UTC) #3
tjblasi
6 years, 5 months ago (2014-07-15 18:07:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r38245 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698