Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: pkg/source_maps/lib/parser.dart

Issue 397693002: Allow updating the `targetUrl` property of SingleMapping. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Removing unnecessary '= null' per review comment. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/source_maps/lib/parser.dart
diff --git a/pkg/source_maps/lib/parser.dart b/pkg/source_maps/lib/parser.dart
index f53f7edcc743b3fb5ded10d28607b58429c4c0ed..3fd0d1445a659f084f46fb272d28a367a4993e48 100644
--- a/pkg/source_maps/lib/parser.dart
+++ b/pkg/source_maps/lib/parser.dart
@@ -136,9 +136,6 @@ class MultiSectionMapping extends Mapping {
/// A map containing direct source mappings.
class SingleMapping extends Mapping {
- /// Url of the target file.
- final String targetUrl;
-
/// Source urls used in the mapping, indexed by id.
final List<String> urls;
@@ -148,10 +145,13 @@ class SingleMapping extends Mapping {
/// Entries indicating the beginning of each span.
final List<TargetLineEntry> lines;
+ /// Url of the target file.
+ String targetUrl;
+
/// Source root appended to the start of all entries in [urls].
- String sourceRoot = null;
+ String sourceRoot;
- SingleMapping._internal(this.targetUrl, this.urls, this.names, this.lines);
+ SingleMapping._(this.targetUrl, this.urls, this.names, this.lines);
factory SingleMapping.fromEntries(
Iterable<builder.Entry> entries, [String fileUrl]) {
@@ -191,7 +191,7 @@ class SingleMapping extends Mapping {
srcNameId));
}
}
- return new SingleMapping._internal(
+ return new SingleMapping._(
fileUrl, urls.keys.toList(), names.keys.toList(), lines);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698