Issue 39713002: Use while(condition) around monitor wait, in file_system_watcher_macos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 39713002: Use while(condition) around monitor wait, in file_system_watcher_macos. (Closed)

Created:
7 years, 2 months ago by Anders Johnsen

Modified:
7 years, 2 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use while(condition) around monitor wait, in file_system_watcher_macos. This fixes a potential threading-issue, where the wacther could be used before it was fully initialized, if 'wait' woke up before notify. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29163

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	runtime/bin/file_system_watcher_macos.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

7 years, 2 months ago (2013-10-24 10:24:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r29163 (presubmit successful).

Expand Messages | Collapse Messages