runtime/bin/file_system_watcher_macos.cc - Issue 39713002: Use while(condition) around monitor wait, in file_system_watcher_macos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/file_system_watcher_macos.cc

Issue 39713002: Use while(condition) around monitor wait, in file_system_watcher_macos. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/file_system_watcher_macos.cc

diff --git a/runtime/bin/file_system_watcher_macos.cc b/runtime/bin/file_system_watcher_macos.cc

index 6d51e9114baedf5771291eeb1ce933e2ab2193ab..1ae1810f65d2355a182c4dcfaacef4a5f9eeda18 100644

--- a/runtime/bin/file_system_watcher_macos.cc

+++ b/runtime/bin/file_system_watcher_macos.cc

@@ -136,7 +136,9 @@ class FSEventsWatcher {

if (watcher == NULL) {

watcher_monitor->Enter();

watcher = new FSEventsWatcher();

- watcher_monitor->Wait(Monitor::kNoTimeout);

+ while (watcher->run_loop_ == NULL) {

+ watcher_monitor->Wait(Monitor::kNoTimeout);

+ }

watcher_monitor->Exit();

}

watcher->users_++;

« no previous file with comments | « no previous file | no next file » | no next file with comments »