Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 396773003: Don't allow running global executables outside of bin. (Closed)

Created:
6 years, 5 months ago by Bob Nystrom
Modified:
6 years, 5 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't allow running global executables outside of bin. BUG=https://code.google.com/p/dart/issues/detail?id=19993 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=38353

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M sdk/lib/_internal/pub/lib/src/command/global_run.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/executable.dart View 1 chunk +6 lines, -2 lines 0 comments Download
A + sdk/lib/_internal/pub/test/global/run/errors_if_outside_bin_test.dart View 1 chunk +13 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
6 years, 5 months ago (2014-07-16 21:46:52 UTC) #1
nweiz
lgtm
6 years, 5 months ago (2014-07-17 07:12:19 UTC) #2
Bob Nystrom
6 years, 5 months ago (2014-07-17 22:23:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38353 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698