Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: sdk/lib/_internal/pub/test/global/run/errors_if_outside_bin_test.dart

Issue 396773003: Don't allow running global executables outside of bin. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/executable.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/test/global/run/errors_if_outside_bin_test.dart
diff --git a/sdk/lib/_internal/pub/test/global/run/runs_script_test.dart b/sdk/lib/_internal/pub/test/global/run/errors_if_outside_bin_test.dart
similarity index 55%
copy from sdk/lib/_internal/pub/test/global/run/runs_script_test.dart
copy to sdk/lib/_internal/pub/test/global/run/errors_if_outside_bin_test.dart
index 217758f26c34cecdc342d1cf6ecf6a42178e0d30..ff137837bdaf2440d665b4128332e0a78870947d 100644
--- a/sdk/lib/_internal/pub/test/global/run/runs_script_test.dart
+++ b/sdk/lib/_internal/pub/test/global/run/errors_if_outside_bin_test.dart
@@ -2,25 +2,33 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+import 'package:path/path.dart' as p;
+
import '../../../lib/src/exit_codes.dart' as exit_codes;
import '../../descriptor.dart' as d;
import '../../test_pub.dart';
main() {
initConfig();
- integration('runs a script in an activated package', () {
+ integration('errors if the script is in a subdirectory.', () {
servePackages([
packageMap("foo", "1.0.0")
], contents: [
- d.dir("bin", [
+ d.dir("example", [
d.file("script.dart", "main(args) => print('ok');")
])
]);
schedulePub(args: ["global", "activate", "foo"]);
+ schedulePub(args: ["global", "run", "foo", "example/script"],
+ error: """
+Cannot run an executable in a subdirectory of a global package.
+
+Usage: pub global run <package> <executable> [args...]
+-h, --help Print usage information for this command.
- var pub = pubRun(global: true, args: ["foo", "script"]);
- pub.stdout.expect("ok");
- pub.shouldExit();
+Run "pub help" to see global options.
+""",
+ exitCode: exit_codes.USAGE);
});
}
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/executable.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698