Sanitize library names generated from file paths

Sanitize library names generated from file paths

BUG=19012
R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38213

[Siggi Cherem (dart-lang), 2014-07-14 19:34:11]

lgtm, thanks Jake!

https://codereview.chromium.org/394523002/diff/1/pkg/polymer/lib/src/build/im...
File pkg/polymer/lib/src/build/import_inliner.dart (right):

https://codereview.chromium.org/394523002/diff/1/pkg/polymer/lib/src/build/im...
pkg/polymer/lib/src/build/import_inliner.dart:249: name = name.replaceAll('-',
'_');
alternatively, we could remove this line and make the replacement '_' below
(instead of ''). I'm good either way though.

https://codereview.chromium.org/394523002/diff/1/pkg/polymer/test/build/impor...
File pkg/polymer/test/build/import_inliner_test.dart (right):

https://codereview.chromium.org/394523002/diff/1/pkg/polymer/test/build/impor...
pkg/polymer/test/build/import_inliner_test.dart:186: 'library
a.web._01_test_html_0;\n/*1*/',     // Appends an _ if it starts with a number.
nit: long lines. We can simply move the comments to the line above it.

[jakemac, 2014-07-14 20:30:24]

https://codereview.chromium.org/394523002/diff/1/pkg/polymer/lib/src/build/im...
File pkg/polymer/lib/src/build/import_inliner.dart (right):

https://codereview.chromium.org/394523002/diff/1/pkg/polymer/lib/src/build/im...
pkg/polymer/lib/src/build/import_inliner.dart:249: name = name.replaceAll('-',
'_');
On 2014/07/14 19:34:11, Siggi Cherem (dart-lang) wrote:
> alternatively, we could remove this line and make the replacement '_' below
> (instead of ''). I'm good either way though.

Actually I kind of like that idea, less likelihood of name collisions if we
replace all special characters with something.

[jakemac, 2014-07-14 20:35:32]

Committed patchset #3 manually as r38213 (presubmit successful).