Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/polymer/test/build/import_inliner_test.dart

Issue 394523002: Sanitize library names generated from file paths (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix formatting and update comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer/lib/src/build/import_inliner.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/test/build/import_inliner_test.dart
diff --git a/pkg/polymer/test/build/import_inliner_test.dart b/pkg/polymer/test/build/import_inliner_test.dart
index 281a3132a7d71bf1c9d7be4b61063f3c2c8fed5c..7fd955302b47993ba650b3d29ed1a94ff65dec84 100644
--- a/pkg/polymer/test/build/import_inliner_test.dart
+++ b/pkg/polymer/test/build/import_inliner_test.dart
@@ -159,6 +159,41 @@ void importTests() {
'a|web/second.js': '/*second*/'
});
+ testPhases('Cleans library names generated from file paths.', phases,
+ {
+ 'a|web/01_test.html':
+ '<!DOCTYPE html><html><head>'
+ '<script type="application/dart">/*1*/</script>'
+ '</head></html>',
+ 'a|web/foo_02_test.html':
+ '<!DOCTYPE html><html><head>'
+ '<script type="application/dart">/*2*/</script>'
+ '</head></html>',
+ 'a|web/test_03.html':
+ '<!DOCTYPE html><html><head>'
+ '<script type="application/dart">/*3*/</script>'
+ '</head></html>',
+ 'a|web/*test_%foo_04!.html':
+ '<!DOCTYPE html><html><head>'
+ '<script type="application/dart">/*4*/</script>'
+ '</head></html>',
+ 'a|web/%05_test.html':
+ '<!DOCTYPE html><html><head>'
+ '<script type="application/dart">/*5*/</script>'
+ '</head></html>',
+ }, {
+ 'a|web/01_test.html.0.dart':
+ 'library a.web._01_test_html_0;\n/*1*/', // Appends an _ if it starts with a number.
+ 'a|web/foo_02_test.html.0.dart':
+ 'library a.web.foo_02_test_html_0;\n/*2*/', // Allows numbers in the middle.
+ 'a|web/test_03.html.0.dart':
+ 'library a.web.test_03_html_0;\n/*3*/', // Allows numbers at the end.
+ 'a|web/*test_%foo_04!.html.0.dart':
+ 'library a.web._test__foo_04__html_0;\n/*4*/', // Replaces invalid characters with _.
+ 'a|web/%05_test.html.0.dart':
+ 'library a.web._05_test_html_0;\n/*5*/', // Replace invalid character followed by number.
+ });
+
testPhases('no transformation outside web/', phases,
{
'a|lib/test.html':
@@ -741,7 +776,7 @@ void stylesheetTests() {
'a|web/test2.css':
'h1 { font-size: 70px; }',
});
-
+
testPhases('inlined tags keep original attributes', phases, {
'a|web/test.html':
'<!DOCTYPE html><html><head>'
@@ -787,7 +822,7 @@ void urlAttributeTests() {
'<script src="baz.jpg"></script>',
'a|web/foo/test_2.html':
'<foo-element src="baz.jpg"></foo-element>',
- });
+ });
}
void entryPointTests() {
@@ -807,7 +842,7 @@ void entryPointTests() {
'<script rel="import" href="../packages/b/bar/bar.js"></script>'
'</body></html>',
});
-
+
testPhases('two level deep entry points normalize correctly', phases, {
'a|web/test/well/test.html':
'<!DOCTYPE html><html><head>'
@@ -822,5 +857,5 @@ void entryPointTests() {
'<!DOCTYPE html><html><head></head><body>'
'<script rel="import" href="../../packages/b/bar/bar.js"></script>'
'</body></html>',
- });
+ });
}
« no previous file with comments | « pkg/polymer/lib/src/build/import_inliner.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698