Issue 393683002: Remove assumption in Dart_GetClosureInfo that func->cls->script = func->script,which was broken in …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 393683002: Remove assumption in Dart_GetClosureInfo that func->cls->script = func->script,which was broken in … (Closed)

Created:
6 years, 5 months ago by rmacnak

Modified:
6 years, 5 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Remove assumption in Dart_GetClosureInfo that func->cls->script = func->script,which was broken in r38140. BUG= R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=38219

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	runtime/vm/debugger_api_impl.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

hausner

LGTM, however, I wish we'd hide these synthetic functions from the debugger.

6 years, 5 months ago (2014-07-14 22:35:10 UTC) #2

rmacnak

6 years, 5 months ago (2014-07-14 23:02:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r38219 (presubmit successful).