Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: runtime/vm/debugger_api_impl.cc

Issue 393683002: Remove assumption in Dart_GetClosureInfo that func->cls->script = func->script,which was broken in … (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger_api_impl.cc
diff --git a/runtime/vm/debugger_api_impl.cc b/runtime/vm/debugger_api_impl.cc
index cabf9e7439a889a7b03235be93c6ba0921dc072f..05ee325e675b6566a94aa76d69420a05304fd07e 100644
--- a/runtime/vm/debugger_api_impl.cc
+++ b/runtime/vm/debugger_api_impl.cc
@@ -697,7 +697,8 @@ DART_EXPORT Dart_Handle Dart_GetClosureInfo(
ASSERT(!cls.IsNull());
const Library& lib = Library::Handle(isolate, cls.library());
ASSERT(!lib.IsNull());
- const Script& script = Script::Handle(cls.script());
+ // Note func.script() is not the same as cls.script() for eval functions.
+ const Script& script = Script::Handle(func.script());
ASSERT(!script.IsNull());
location->script_url = Api::NewHandle(isolate, script.url());
location->library_id = lib.index();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698