Issue 392043003: The dart version of typeddata library has changed to be compatible with the dart2js implementation

Issue 392043003: The dart version of typeddata library has changed to be compatible with the dart2js implementation (Closed)

Created:
6 years, 5 months ago by siva

Modified:
6 years, 5 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

The dart version of typeddata library has changed to be compatible with the dart2js implementation (typeddata does not implement ByteBuffer anymore). Added new Dart API functions to account for this change. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=38351

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+222 lines, -12 lines)			Patch
M	runtime/include/dart_api.h	View	1 2 3 4	3 chunks	+22 lines, -0 lines	0 comments	Download
M	runtime/lib/typed_data.dart	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/class_finalizer.cc	View	1 2 3 4	1 chunk	+12 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 2 3 4	5 chunks	+80 lines, -2 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 2 3 4	2 chunks	+47 lines, -0 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2 3 4	2 chunks	+23 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3 4	2 chunks	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/raw_object.h	View	1 2 3 4	7 chunks	+18 lines, -5 lines	0 comments	Download
M	runtime/vm/raw_object.cc	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/snapshot.cc	View	1 2 3 4	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/standalone/issue14236_test.dart	View	1	Binary file		0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Cutch

lgtm with minor suggestion https://codereview.chromium.org/392043003/diff/60001/runtime/vm/snapshot.cc File runtime/vm/snapshot.cc (right): https://codereview.chromium.org/392043003/diff/60001/runtime/vm/snapshot.cc#newcode60 runtime/vm/snapshot.cc:60: (class_id == kByteBufferCid))); Maybe factor ...

6 years, 5 months ago (2014-07-16 21:34:33 UTC) #2

siva

https://codereview.chromium.org/392043003/diff/60001/runtime/vm/snapshot.cc File runtime/vm/snapshot.cc (right): https://codereview.chromium.org/392043003/diff/60001/runtime/vm/snapshot.cc#newcode60 runtime/vm/snapshot.cc:60: (class_id == kByteBufferCid))); On 2014/07/16 21:34:33, Cutch wrote: > ...

6 years, 5 months ago (2014-07-17 21:36:55 UTC) #3

siva

6 years, 5 months ago (2014-07-17 22:08:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r38351 (presubmit successful).

Expand Messages | Collapse Messages