Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: runtime/vm/class_finalizer.cc

Issue 392043003: The dart version of typeddata library has changed to be compatible with the dart2js implementation (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/typed_data.dart ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/class_finalizer.cc
===================================================================
--- runtime/vm/class_finalizer.cc (revision 38347)
+++ runtime/vm/class_finalizer.cc (working copy)
@@ -3034,6 +3034,18 @@
ASSERT(field.Offset() == TypedDataView::length_offset());
name ^= field.name();
ASSERT(name.Equals("length"));
+
+ // Now verify field offsets of '_ByteBuffer' class.
+ cls = class_table.At(kByteBufferCid);
+ error = cls.EnsureIsFinalized(isolate);
+ ASSERT(error.IsNull());
+ fields_array ^= cls.fields();
+ ASSERT(fields_array.Length() == ByteBuffer::NumberOfFields());
+ field ^= fields_array.At(0);
+ ASSERT(field.Offset() == ByteBuffer::data_offset());
+ name ^= field.name();
+ expected_name ^= String::New("_data");
+ ASSERT(String::EqualsIgnoringPrivateKey(name, expected_name));
#endif
}
« no previous file with comments | « runtime/lib/typed_data.dart ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698