Issue 38753008: test.py: Support for running tests in checked mode on none-dartium with the browser controller

Issue 38753008: test.py: Support for running tests in checked mode on none-dartium with the browser controller (Closed)

Created:
7 years, 1 month ago by kustermann

Modified:
7 years, 1 month ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

test.py: Support for running tests in checked mode on none-dartium with the browser controller R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=29175

Patch Set 4 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -45 lines)			Patch
dart/tests/co19/co19-dartium.status	View	1 2	2 chunks	+13 lines, -1 line	0 comments	Download
dart/tests/co19/co19-runtime.status	View		2 chunks	+2 lines, -2 lines	0 comments	Download
dart/tests/language/language.status	View	1 2	2 chunks	+12 lines, -12 lines	0 comments	Download
dart/tests/standalone/standalone.status	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
dart/tools/testing/dart/browser_controller.dart	View	1 2	6 chunks	+14 lines, -5 lines	0 comments	Download
dart/tools/testing/dart/test_options.dart	View		1 chunk	+0 lines, -9 lines	0 comments	Download
dart/tools/testing/dart/test_runner.dart	View	1 2	7 chunks	+23 lines, -13 lines	0 comments	Download
dart/tools/testing/dart/test_suite.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM with small correction As discussed offline you probably need to adjust some more status ...

7 years, 1 month ago (2013-10-24 15:07:18 UTC) #2

kustermann

https://codereview.chromium.org/38753008/diff/30001/dart/tools/testing/dart/browser_controller.dart File dart/tools/testing/dart/browser_controller.dart (right): https://codereview.chromium.org/38753008/diff/30001/dart/tools/testing/dart/browser_controller.dart#newcode666 dart/tools/testing/dart/browser_controller.dart:666: final bool checkedMode; On 2013/10/24 15:07:19, ricow1 wrote: > ...

7 years, 1 month ago (2013-10-24 15:36:13 UTC) #3

kustermann

7 years, 1 month ago (2013-10-24 15:37:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r29175 (presubmit successful).

Expand Messages | Collapse Messages