Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: dart/tools/testing/dart/test_options.dart

Issue 38753008: test.py: Support for running tests in checked mode on none-dartium with the browser controller (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tools/testing/dart/browser_controller.dart ('k') | dart/tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/test_options.dart
diff --git a/dart/tools/testing/dart/test_options.dart b/dart/tools/testing/dart/test_options.dart
index 38d45a73b15578d732729b521168a19be0fb3a64..0d69ba682b1a88d74f3280ea6774a6a5311fd64a 100644
--- a/dart/tools/testing/dart/test_options.dart
+++ b/dart/tools/testing/dart/test_options.dart
@@ -533,15 +533,6 @@ Note: currently only implemented for dart2js.''',
print("Error: shard index is ${config['shard']} out of "
"${config['shards']} shards");
}
- if (config['runtime'] == 'dartium' &&
- const ['none', 'dart2dart'].contains(config['compiler']) &&
- config['checked']) {
- // TODO(vsm): Set the DART_FLAGS environment appropriately when
- // invoking Selenium to support checked mode. It's not clear
- // the current selenium API supports this.
- isValid = false;
- print("Warning: checked mode is not yet supported for dartium tests.");
- }
return isValid;
}
« no previous file with comments | « dart/tools/testing/dart/browser_controller.dart ('k') | dart/tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698