Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 387323002: Fix error message for unexpected characters in JSON. (Closed)

Created:
6 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 5 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix error message for unexpected characters in JSON. The current version treats any unexpected character as a number error. R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=38184 Committed: https://code.google.com/p/dart/source/detail?r=38185

Patch Set 1 #

Patch Set 2 : Actually fix the problem, using existing variables. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M runtime/lib/convert_patch.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/convert/json_test.dart View 1 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lasse Reichstein Nielsen
6 years, 5 months ago (2014-07-14 10:37:36 UTC) #1
kustermann
lgtm
6 years, 5 months ago (2014-07-14 10:39:45 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #1 manually as r38184 (presubmit successful).
6 years, 5 months ago (2014-07-14 10:41:03 UTC) #3
Lasse Reichstein Nielsen
6 years, 5 months ago (2014-07-14 11:02:46 UTC) #4
Lasse Reichstein Nielsen
Committed patchset #2 manually as r38185 (presubmit successful).
6 years, 5 months ago (2014-07-14 11:08:45 UTC) #5
kustermann
6 years, 5 months ago (2014-07-14 11:11:03 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698