runtime/lib/convert_patch.dart - Issue 387323002: Fix error message for unexpected characters in JSON.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/convert_patch.dart

Issue 387323002: Fix error message for unexpected characters in JSON. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Actually fix the problem, using existing variables. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/convert_patch.dart

diff --git a/runtime/lib/convert_patch.dart b/runtime/lib/convert_patch.dart

index 39617dc7a0fc83ee077d51e15eb986114ec07682..8bd7e4001fe398a15c2004be51666a955b6d2f46 100644

--- a/runtime/lib/convert_patch.dart

+++ b/runtime/lib/convert_patch.dart

@@ -504,7 +504,7 @@ class _JsonParser {

char = source.codeUnitAt(position);

}

if (char < CHAR_0 || char > CHAR_9) {

- if (negative) {

+ if (intSign < 0) {

fail(position, "Missing expected digit");

} else {

// If it doesn't even start out as a numeral.

« no previous file with comments | « no previous file | tests/lib/convert/json_test.dart » ('j') | no next file with comments »