Align behavior of VM's ObjectMirror.setField with language semantics.

Align behavior of VM's ObjectMirror.setField with language semantics.

R=ahe@google.com, asiva@google.com, gbracha@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29692

[gbracha, 2013-10-24 01:57:10]

tests lgtm

[ahe, 2013-10-24 13:22:03]

lgtm

[ahe, 2013-10-24 13:22:18]

On 2013/10/24 13:22:03, ahe wrote:
> lgtm

I only looked at the tests :-)

[siva, 2013-10-28 02:07:10]

https://codereview.chromium.org/38543002/diff/20001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/38543002/diff/20001/runtime/lib/mirrors.cc#ne...
runtime/lib/mirrors.cc:1613: setter,
setter could be potentially Null here (case where field.IsNull() is false). That
seems odd.

https://codereview.chromium.org/38543002/diff/20001/runtime/lib/mirrors.cc#ne...
runtime/lib/mirrors.cc:1865: setter,
Ditto question about setter being Null

[rmacnak, 2013-10-28 17:14:05]

https://codereview.chromium.org/38543002/diff/20001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/38543002/diff/20001/runtime/lib/mirrors.cc#ne...
runtime/lib/mirrors.cc:1613: setter,
On 2013/10/28 02:07:11, siva wrote:
> setter could be potentially Null here (case where field.IsNull() is false).
That
> seems odd.

Right. Usually the function passed to ThrowNoSuchMethod is null. If a function
is found but it has the wrong arity, the function is non-null and used to
generate better error messages (e.g., names of expected parameters). This
doesn't happen for setters because they have a guaranteed arity, but it does
happen with ordinary invocations.

[siva, 2013-10-31 17:40:50]

lgtm

[rmacnak, 2013-10-31 20:21:09]

Committed patchset #2 manually as r29692 (presubmit successful).