Align behavior of VM's ObjectMirror.setField with language semantics.

runtime/lib/mirrors.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "lib/invocation_mirror.h"
 #include "vm/bootstrap_natives.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart_entry.h"
 #include "vm/exceptions.h"
@@ skipping 1358 matching lines @@
 
 
 DEFINE_NATIVE_ENTRY(InstanceMirror_invokeSetter, 4) {
   // Argument 0 is the mirror, which is unused by the native. It exists
   // because this native is an instance method in order to be polymorphic
   // with its cousins.
   GET_NATIVE_ARGUMENT(Instance, reflectee, arguments->NativeArgAt(1));
   GET_NON_NULL_NATIVE_ARGUMENT(String, setter_name, arguments->NativeArgAt(2));
   GET_NATIVE_ARGUMENT(Instance, value, arguments->NativeArgAt(3));
 
-  String& internal_setter_name =
+  const Class& klass = Class::Handle(reflectee.clazz());
+  const String& internal_setter_name =
       String::Handle(Field::SetterName(setter_name));
-  Function& setter = Function::Handle();
+  const Function& setter = Function::Handle(
+      Resolver::ResolveDynamicAnyArgs(klass, internal_setter_name));
 
-  Class& klass = Class::Handle(reflectee.clazz());
-  Field& field = Field::Handle();
-
-  while (!klass.IsNull()) {
-    field = klass.LookupInstanceField(setter_name);
-    if (!field.IsNull() && field.is_final()) {
-      const String& message = String::Handle(
-          String::NewFormatted("%s: cannot set final field '%s'.",
-                               "InstanceMirror_invokeSetter",
-                               setter_name.ToCString()));
-      ThrowMirroredCompilationError(message);
-      UNREACHABLE();
-    }
-    setter = klass.LookupDynamicFunction(internal_setter_name);
-    if (!setter.IsNull()) {
-      break;
-    }
-    klass = klass.SuperClass();
-  }
-
-  // Invoke the setter and return the result.
   const int kNumArgs = 2;
   const Array& args = Array::Handle(Array::New(kNumArgs));
   args.SetAt(0, reflectee);
   args.SetAt(1, value);
   const Array& args_descriptor =
       Array::Handle(ArgumentsDescriptor::New(args.Length()));
 
   return InvokeDynamicFunction(reflectee,
                                setter,
                                internal_setter_name,
@@ skipping 175 matching lines @@
   // Argument 0 is the mirror, which is unused by the native. It exists
   // because this native is an instance method in order to be polymorphic
   // with its cousins.
   GET_NON_NULL_NATIVE_ARGUMENT(MirrorReference, ref, arguments->NativeArgAt(1));
   const Class& klass = Class::Handle(ref.GetClassReferent());
   GET_NON_NULL_NATIVE_ARGUMENT(String, setter_name, arguments->NativeArgAt(2));
   GET_NATIVE_ARGUMENT(Instance, value, arguments->NativeArgAt(3));
 
   // Check for real fields and user-defined setters.
   const Field& field = Field::Handle(klass.LookupStaticField(setter_name));
+  Function& setter = Function::Handle();
   if (field.IsNull()) {
     const String& internal_setter_name = String::Handle(
       Field::SetterName(setter_name));
-    const Function& setter = Function::Handle(
-      klass.LookupStaticFunction(internal_setter_name));
+
+    setter = klass.LookupStaticFunction(internal_setter_name);
 
     if (setter.IsNull() || !setter.is_visible()) {
       ThrowNoSuchMethod(AbstractType::Handle(klass.RareType()),
                         setter_name,
                         setter,
                         InvocationMirror::kStatic,
                         InvocationMirror::kSetter);
       UNREACHABLE();
     }
 
     // Invoke the setter and return the result.
     const int kNumArgs = 1;
     const Array& args = Array::Handle(Array::New(kNumArgs));
     args.SetAt(0, value);
 
     Object& result = Object::Handle(
         DartEntry::InvokeFunction(setter, args));
     if (result.IsError()) {
       ThrowInvokeError(Error::Cast(result));
       UNREACHABLE();
     }
     return result.raw();
   }
 
   if (field.is_final()) {
-    const String& message = String::Handle(
-        String::NewFormatted("%s: cannot set final field '%s'.",
-                             "ClassMirror_invokeSetter",
-                             setter_name.ToCString()));
-    ThrowMirroredCompilationError(message);
+    ThrowNoSuchMethod(AbstractType::Handle(klass.RareType()),
+                      setter_name,
+                      setter,
+                      InvocationMirror::kStatic,
+                      InvocationMirror::kSetter);
     UNREACHABLE();
   }
 
   field.set_value(value);
   return value.raw();
 }
 
 
 DEFINE_NATIVE_ENTRY(ClassMirror_invokeConstructor, 5) {
   GET_NON_NULL_NATIVE_ARGUMENT(MirrorReference, ref, arguments->NativeArgAt(0));
@@ skipping 197 matching lines @@
   GET_NON_NULL_NATIVE_ARGUMENT(MirrorReference, ref, arguments->NativeArgAt(1));
   const Library& library = Library::Handle(ref.GetLibraryReferent());
   GET_NON_NULL_NATIVE_ARGUMENT(String, setter_name, arguments->NativeArgAt(2));
   GET_NATIVE_ARGUMENT(Instance, value, arguments->NativeArgAt(3));
 
   // To access a top-level we may need to use the Field or the
   // setter Function.  The setter function may either be in the
   // library or in the field's owner class, depending.
   const Field& field = Field::Handle(
       library.LookupLocalField(setter_name));
+  Function& setter = Function::Handle();
 
   if (field.IsNull()) {
     const String& internal_setter_name =
         String::Handle(Field::SetterName(setter_name));
-    const Function& setter = Function::Handle(
-        library.LookupLocalFunction(internal_setter_name));
+
+    setter = library.LookupLocalFunction(internal_setter_name);
     if (setter.IsNull() || !setter.is_visible()) {
       ThrowNoSuchMethod(Instance::null_instance(),
                         setter_name,
                         setter,
                         InvocationMirror::kTopLevel,
                         InvocationMirror::kSetter);
       UNREACHABLE();
     }
 
     // Invoke the setter and return the result.
     const int kNumArgs = 1;
     const Array& args = Array::Handle(Array::New(kNumArgs));
     args.SetAt(0, value);
     const Object& result = Object::Handle(
         DartEntry::InvokeFunction(setter, args));
     if (result.IsError()) {
       ThrowInvokeError(Error::Cast(result));
       UNREACHABLE();
     }
     return result.raw();
   }
 
   if (field.is_final()) {
-    const String& message = String::Handle(
-      String::NewFormatted("%s: cannot set final top-level variable '%s'.",
-                           "LibraryMirror_invokeSetter",
-                           setter_name.ToCString()));
-    ThrowMirroredCompilationError(message);
+    ThrowNoSuchMethod(Instance::null_instance(),
+                      setter_name,
+                      setter,
+                      InvocationMirror::kTopLevel,
+                      InvocationMirror::kSetter);
     UNREACHABLE();
   }
 
   field.set_value(value);
   return value.raw();
 }
 
 
 DEFINE_NATIVE_ENTRY(MethodMirror_owner, 1) {
   GET_NON_NULL_NATIVE_ARGUMENT(MirrorReference, ref, arguments->NativeArgAt(0));
@@ skipping 79 matching lines @@
 }
 
 
 DEFINE_NATIVE_ENTRY(VariableMirror_type, 1) {
   GET_NON_NULL_NATIVE_ARGUMENT(MirrorReference, ref, arguments->NativeArgAt(0));
   const Field& field = Field::Handle(ref.GetFieldReferent());
   return field.type();
 }
 
 }  // namespace dart