Faster JSNumber:toInt.

Faster JSNumber:toInt.

R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29162

[Lasse Reichstein Nielsen, 2013-10-24 08:00:27]

LGTM!

https://codereview.chromium.org/38353005/diff/1/sdk/lib/_internal/lib/js_numb...
File sdk/lib/_internal/lib/js_number.dart (right):

https://codereview.chromium.org/38353005/diff/1/sdk/lib/_internal/lib/js_numb...
sdk/lib/_internal/lib/js_number.dart:68: }
Are there any tests of toInt anywhere? Perhaps disguised as truncate tests.

If so, please make sure that they test values around the min/max-int values as
well. At least:
  -0x80000001
  -0x80000000 - 0.7
  -0x80000000 - 0.3
  -0x80000000 + 0.3
  -0x80000000 + 0.7
  -0x7FFFFFFF
   0x7FFFFFFE
   0x7FFFFFFF - 0.7
   0x7FFFFFFF - 0.3
   0x7FFFFFFF + 0.3
   0x7FFFFFFF + 0.7
   0x80000000

[ngeoffray, 2013-10-24 08:07:04]

Thanks Lasse.

https://codereview.chromium.org/38353005/diff/1/sdk/lib/_internal/lib/js_numb...
File sdk/lib/_internal/lib/js_number.dart (right):

https://codereview.chromium.org/38353005/diff/1/sdk/lib/_internal/lib/js_numb...
sdk/lib/_internal/lib/js_number.dart:68: }
On 2013/10/24 08:00:27, Lasse Reichstein Nielsen wrote:
> Are there any tests of toInt anywhere? Perhaps disguised as truncate tests.
> 
> If so, please make sure that they test values around the min/max-int values as
> well. At least:
>   -0x80000001
>   -0x80000000 - 0.7
>   -0x80000000 - 0.3
>   -0x80000000 + 0.3
>   -0x80000000 + 0.7
>   -0x7FFFFFFF
>    0x7FFFFFFE
>    0x7FFFFFFF - 0.7
>    0x7FFFFFFF - 0.3
>    0x7FFFFFFF + 0.3
>    0x7FFFFFFF + 0.7
>    0x80000000

Done.

[ngeoffray, 2013-10-24 08:44:36]

Committed patchset #2 manually as r29162 (presubmit successful).