Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/_internal/lib/js_number.dart

Issue 38353005: Faster JSNumber:toInt. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/corelib/toInt_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/lib/js_number.dart
===================================================================
--- sdk/lib/_internal/lib/js_number.dart (revision 29154)
+++ sdk/lib/_internal/lib/js_number.dart (working copy)
@@ -58,8 +58,14 @@
}
num abs() => JS('num', r'Math.abs(#)', this);
+
+ static const int _MIN_INT32 = -0x80000000;
+ static const int _MAX_INT32 = 0x7FFFFFFF;
int toInt() {
+ if (this >= _MIN_INT32 && this <= _MAX_INT32) {
+ return JS('int', '# | 0', this);
+ }
if (JS('bool', r'isFinite(#)', this)) {
return JS('int', r'# + 0', truncateToDouble()); // Converts -0.0 to +0.0.
}
« no previous file with comments | « no previous file | tests/corelib/toInt_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698