Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 382653002: Report stack overflow to debugger after stack is unwound (Closed)

Created:
6 years, 5 months ago by hausner
Modified:
6 years, 5 months ago
Reviewers:
devoncarew, Jacob
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Visibility:
Public.

Description

Report stack overflow to debugger after stack is unwound Notify the debugger of stack overflow errors after the stack has been unwound. No location information is sent with the pause event. R=devoncarew@google.com Committed: https://code.google.com/p/dart/source/detail?r=38125

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M runtime/bin/dbg_message.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +1 line, -3 lines 0 comments Download
M tools/ddbg.dart View 4 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
Devon, Jacob, can you check whether the Editor and devtools can handle the paused event ...
6 years, 5 months ago (2014-07-09 21:26:53 UTC) #1
devoncarew
lgtm I patched this in and verified that the editor's debugger handles an empty stack ...
6 years, 5 months ago (2014-07-09 22:31:07 UTC) #2
hausner
Committed patchset #1 manually as r38125 (presubmit successful).
6 years, 5 months ago (2014-07-10 17:44:37 UTC) #3
hausner
6 years, 5 months ago (2014-07-10 17:45:04 UTC) #4
Message was sent while issue was closed.
Thank you.

Powered by Google App Engine
This is Rietveld 408576698