runtime/vm/isolate.cc - Issue 382653002: Report stack overflow to debugger after stack is unwound

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/isolate.cc

Issue 382653002: Report stack overflow to debugger after stack is unwound (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/isolate.cc

===================================================================

--- runtime/vm/isolate.cc (revision 38090)

+++ runtime/vm/isolate.cc (working copy)

@@ -348,9 +348,7 @@

if ((exception == I->object_store()->out_of_memory()) ||

(exception == I->object_store()->stack_overflow())) {

// We didn't notify the debugger when the stack was full. Do it now.

- // TODO(hausner): uncomment the debugger notification once debuggers

- // can deal with exceptions thrown on an empty stack.

- // I->debugger()->SignalExceptionThrown(Instance::Handle(exception));

+ I->debugger()->SignalExceptionThrown(Instance::Handle(exception));

}

if ((exception != I->object_store()->out_of_memory()) &&

(exception != I->object_store()->stack_overflow())) {

« no previous file with comments | « runtime/bin/dbg_message.cc ('k') | tools/ddbg.dart » ('j') | no next file with comments »