Issue 37813002: Don't return outputs from a removed PhaseInput.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 37813002: Don't return outputs from a removed PhaseInput. (Closed)

Created:
7 years, 2 months ago by nweiz

Modified:
7 years, 2 months ago

Reviewers:
Alan Knight

CC:
reviews_dartlang.org, Bob Nystrom

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Don't return outputs from a removed PhaseInput. Also clean up a few things in Phase. R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=29127

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+35 lines, -7 lines)			Patch
pkg/barback/lib/src/phase.dart	View	1 chunk	+3 lines, -5 lines	0 comments	Download
pkg/barback/lib/src/phase_input.dart	View	1 chunk	+8 lines, -2 lines	0 comments	Download
pkg/barback/test/package_graph/transform_test.dart	View	1 chunk	+24 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Alan Knight

Codereview is giving me an "old chunk mismatch" error on all of this, but fortunately ...

7 years, 2 months ago (2013-10-23 20:59:20 UTC) #2

nweiz

7 years, 2 months ago (2013-10-23 21:19:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r29127 (presubmit successful).