Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: pkg/barback/lib/src/phase.dart

Issue 37813002: Don't return outputs from a removed PhaseInput. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/barback/lib/src/phase_input.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/lib/src/phase.dart
diff --git a/pkg/barback/lib/src/phase.dart b/pkg/barback/lib/src/phase.dart
index ab39f7170ba87037bb59af38a5a20136bbf56a15..8680e6017b0e69a33c52469b1f00d0039b4e0067 100644
--- a/pkg/barback/lib/src/phase.dart
+++ b/pkg/barback/lib/src/phase.dart
@@ -281,13 +281,11 @@ class Phase {
if (!input.isDirty) return new Future.value(new Set());
return input.process().then(_handleOutputs);
}));
- outputFutures.addAll(_groups.values.map((input) {
- if (!input.isDirty) return new Future.value(new Set());
- return input.process().then(_handleOutputs);
+ outputFutures.addAll(_groups.values.map((group) {
+ if (!group.isDirty) return new Future.value(new Set());
+ return group.process().then(_handleOutputs);
}));
- // TODO(nweiz): handle pass-through.
-
return Future.wait(outputFutures).then((_) {
// Report collisions in a deterministic order.
outputIds = outputIds.toList();
« no previous file with comments | « no previous file | pkg/barback/lib/src/phase_input.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698