Issue 377053002: Tests for LocalIndex and Dart index contributor.

Issue 377053002: Tests for LocalIndex and Dart index contributor. (Closed)

Created:
6 years, 5 months ago by scheglov

Modified:
6 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Tests for LocalIndex and Dart index contributor. Pub spec files will be updated before commit. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38071

Patch Set 1 #

Total comments: 6

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1835 lines, -159 lines)			Patch
M	pkg/analysis_services/lib/src/index/index_contributor.dart	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	pkg/analysis_services/pubspec.yaml	View	1 chunk	+2 lines, -1 line	2 comments	Download
A	pkg/analysis_services/test/index/dart_index_contributor_test.dart	View	1 chunk	+1654 lines, -0 lines	4 comments	Download
A	pkg/analysis_services/test/index/local_file_index_test.dart	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	pkg/analysis_services/test/index/local_index_test.dart	View	1 chunk	+139 lines, -150 lines	0 comments	Download
M	pkg/analysis_services/test/index/test_all.dart	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	pkg/analysis_testing/lib/abstract_context.dart	View	4 chunks	+7 lines, -6 lines	0 comments	Download
M	pkg/analysis_testing/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/377053002/diff/1/pkg/analysis_services/pubspec.yaml File pkg/analysis_services/pubspec.yaml (right): https://codereview.chromium.org/377053002/diff/1/pkg/analysis_services/pubspec.yaml#newcode12 pkg/analysis_services/pubspec.yaml:12: path: /Users/scheglov/Source/Dart/dart/pkg/analysis_testing I assume your comment meant that ...

6 years, 5 months ago (2014-07-08 20:07:58 UTC) #2

scheglov

Committed patchset #1 manually as r38071 (presubmit successful).

6 years, 5 months ago (2014-07-08 20:53:18 UTC) #3

scheglov

6 years, 5 months ago (2014-07-08 20:54:52 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/377053002/diff/1/pkg/analysis_services/pubspe...
File pkg/analysis_services/pubspec.yaml (right):

https://codereview.chromium.org/377053002/diff/1/pkg/analysis_services/pubspe...
pkg/analysis_services/pubspec.yaml:12: path:
/Users/scheglov/Source/Dart/dart/pkg/analysis_testing
On 2014/07/08 20:07:58, Brian Wilkerson wrote:
> I assume your comment meant that this change would not be committed.

Correct.
Done.

https://codereview.chromium.org/377053002/diff/1/pkg/analysis_services/test/i...
File pkg/analysis_services/test/index/dart_index_contributor_test.dart (right):

https://codereview.chromium.org/377053002/diff/1/pkg/analysis_services/test/i...
pkg/analysis_services/test/index/dart_index_contributor_test.dart:30: * Returns
`true` if [actual] location the same properties as [expected].
On 2014/07/08 20:07:58, Brian Wilkerson wrote:
> "if [actual] location the" --> "if the [actual] location has the"

Done.

https://codereview.chromium.org/377053002/diff/1/pkg/analysis_services/test/i...
pkg/analysis_services/test/index/dart_index_contributor_test.dart:39: * Returns
`true` if [actual] location the expected properties.
On 2014/07/08 20:07:58, Brian Wilkerson wrote:
> "if [actual] location the" --> "if the [actual] location has the"

Done.

Expand Messages | Collapse Messages