Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: pkg/analysis_services/lib/src/index/index_contributor.dart

Issue 377053002: Tests for LocalIndex and Dart index contributor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_services/pubspec.yaml » ('j') | pkg/analysis_services/pubspec.yaml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_services/lib/src/index/index_contributor.dart
diff --git a/pkg/analysis_services/lib/src/index/index_contributor.dart b/pkg/analysis_services/lib/src/index/index_contributor.dart
index a6cf5cb7f0276e9b0aabd4568c0524e9765d0730..044418396e146980b9d1806b9a1519b32611558b 100644
--- a/pkg/analysis_services/lib/src/index/index_contributor.dart
+++ b/pkg/analysis_services/lib/src/index/index_contributor.dart
@@ -1075,6 +1075,7 @@ class _IndexContributor extends GeneralizingAstVisitor<Object> {
static Location
_getLocationWithTypeAssignedToField(SimpleIdentifier identifier,
Element element, Location location) {
+ // TODO(scheglov) decide if we want to remember assigned types
// we need accessor
if (element is! PropertyAccessorElement) {
return location;
@@ -1181,7 +1182,7 @@ class _IndexContributor extends GeneralizingAstVisitor<Object> {
}
Namespace namespace = new NamespaceBuilder(
).createImportNamespaceForDirective(importElement);
- Set<Element> elements = new Set();
+ Set<Element> elements = new Set.from(namespace.definedNames.values);
importElementsMap[importElement] = elements;
}
// use import namespace to choose correct one
« no previous file with comments | « no previous file | pkg/analysis_services/pubspec.yaml » ('j') | pkg/analysis_services/pubspec.yaml » ('J')

Powered by Google App Engine
This is Rietveld 408576698