Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 375693004: Don't assign safepoint at the definition to the definition's live-range. (Closed)

Created:
6 years, 5 months ago by Vyacheslav Egorov (Google)
Modified:
6 years, 5 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Don't assign safepoint at the definition to the definition's live-range. This avoids treating spill slot associated with the definition live during GC as it will only be filled in after definition's code is fully executed. Additionally this makes output register dead for GC inside the definiton itself which is something we used to guarantee manually by removing it from the live_registers set before calling on the slow path. BUG= R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=38059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -43 lines) Patch
M runtime/vm/code_generator.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_allocator.h View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/vm/flow_graph_allocator.cc View 9 chunks +23 lines, -15 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/locations.h View 1 chunk +11 lines, -0 lines 0 comments Download
A tests/standalone/slowpath_safepoints_test.dart View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vyacheslav Egorov (Google)
PTAL As discussed in the meeting, this is both repro and the fix. I had ...
6 years, 5 months ago (2014-07-07 23:41:49 UTC) #1
Florian Schneider
LGTM. I think you can mark it as Crash in Debug mode, and maybe Pass/Crash ...
6 years, 5 months ago (2014-07-08 12:29:02 UTC) #2
Vyacheslav Egorov (Google)
Committed patchset #1 manually as r38059 (presubmit successful).
6 years, 5 months ago (2014-07-08 14:12:12 UTC) #3
srdjan
6 years, 5 months ago (2014-07-08 22:28:03 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698