Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: runtime/vm/intermediate_language_arm64.cc

Issue 375693004: Don't assign safepoint at the definition to the definition's live-range. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64.
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1596 matching lines...) Expand 10 before | Expand all | Expand 10 after
1607 1607
1608 virtual void EmitNativeCode(FlowGraphCompiler* compiler) { 1608 virtual void EmitNativeCode(FlowGraphCompiler* compiler) {
1609 __ Comment("StoreInstanceFieldSlowPath"); 1609 __ Comment("StoreInstanceFieldSlowPath");
1610 __ Bind(entry_label()); 1610 __ Bind(entry_label());
1611 1611
1612 const Code& stub = 1612 const Code& stub =
1613 Code::Handle(StubCode::GetAllocationStubForClass(cls_)); 1613 Code::Handle(StubCode::GetAllocationStubForClass(cls_));
1614 const ExternalLabel label(stub.EntryPoint()); 1614 const ExternalLabel label(stub.EntryPoint());
1615 1615
1616 LocationSummary* locs = instruction_->locs(); 1616 LocationSummary* locs = instruction_->locs();
1617 locs->live_registers()->Remove(locs->out(0)); 1617 locs->live_registers()->Remove(locs->temp(0));
1618 1618
1619 compiler->SaveLiveRegisters(locs); 1619 compiler->SaveLiveRegisters(locs);
1620 compiler->GenerateCall(Scanner::kNoSourcePos, // No token position. 1620 compiler->GenerateCall(Scanner::kNoSourcePos, // No token position.
1621 &label, 1621 &label,
1622 RawPcDescriptors::kOther, 1622 RawPcDescriptors::kOther,
1623 locs); 1623 locs);
1624 __ mov(locs->temp(0).reg(), R0); 1624 __ mov(locs->temp(0).reg(), R0);
1625 compiler->RestoreLiveRegisters(locs); 1625 compiler->RestoreLiveRegisters(locs);
1626 1626
1627 __ b(exit_label()); 1627 __ b(exit_label());
(...skipping 349 matching lines...) Expand 10 before | Expand all | Expand 10 after
1977 1977
1978 virtual void EmitNativeCode(FlowGraphCompiler* compiler) { 1978 virtual void EmitNativeCode(FlowGraphCompiler* compiler) {
1979 __ Comment("BoxDoubleSlowPath"); 1979 __ Comment("BoxDoubleSlowPath");
1980 __ Bind(entry_label()); 1980 __ Bind(entry_label());
1981 const Class& double_class = compiler->double_class(); 1981 const Class& double_class = compiler->double_class();
1982 const Code& stub = 1982 const Code& stub =
1983 Code::Handle(StubCode::GetAllocationStubForClass(double_class)); 1983 Code::Handle(StubCode::GetAllocationStubForClass(double_class));
1984 const ExternalLabel label(stub.EntryPoint()); 1984 const ExternalLabel label(stub.EntryPoint());
1985 1985
1986 LocationSummary* locs = instruction_->locs(); 1986 LocationSummary* locs = instruction_->locs();
1987 locs->live_registers()->Remove(locs->out(0)); 1987 ASSERT(!locs->live_registers()->Contains(locs->out(0)));
1988 1988
1989 compiler->SaveLiveRegisters(locs); 1989 compiler->SaveLiveRegisters(locs);
1990 compiler->GenerateCall(Scanner::kNoSourcePos, // No token position. 1990 compiler->GenerateCall(Scanner::kNoSourcePos, // No token position.
1991 &label, 1991 &label,
1992 RawPcDescriptors::kOther, 1992 RawPcDescriptors::kOther,
1993 locs); 1993 locs);
1994 __ mov(locs->out(0).reg(), R0); 1994 __ mov(locs->out(0).reg(), R0);
1995 compiler->RestoreLiveRegisters(locs); 1995 compiler->RestoreLiveRegisters(locs);
1996 1996
1997 __ b(exit_label()); 1997 __ b(exit_label());
(...skipping 11 matching lines...) Expand all
2009 2009
2010 virtual void EmitNativeCode(FlowGraphCompiler* compiler) { 2010 virtual void EmitNativeCode(FlowGraphCompiler* compiler) {
2011 __ Comment("BoxFloat32x4SlowPath"); 2011 __ Comment("BoxFloat32x4SlowPath");
2012 __ Bind(entry_label()); 2012 __ Bind(entry_label());
2013 const Class& float32x4_class = compiler->float32x4_class(); 2013 const Class& float32x4_class = compiler->float32x4_class();
2014 const Code& stub = 2014 const Code& stub =
2015 Code::Handle(StubCode::GetAllocationStubForClass(float32x4_class)); 2015 Code::Handle(StubCode::GetAllocationStubForClass(float32x4_class));
2016 const ExternalLabel label(stub.EntryPoint()); 2016 const ExternalLabel label(stub.EntryPoint());
2017 2017
2018 LocationSummary* locs = instruction_->locs(); 2018 LocationSummary* locs = instruction_->locs();
2019 locs->live_registers()->Remove(locs->out(0)); 2019 ASSERT(!locs->live_registers()->Contains(locs->out(0)));
2020 2020
2021 compiler->SaveLiveRegisters(locs); 2021 compiler->SaveLiveRegisters(locs);
2022 compiler->GenerateCall(Scanner::kNoSourcePos, // No token position. 2022 compiler->GenerateCall(Scanner::kNoSourcePos, // No token position.
2023 &label, 2023 &label,
2024 RawPcDescriptors::kOther, 2024 RawPcDescriptors::kOther,
2025 locs); 2025 locs);
2026 __ mov(locs->out(0).reg(), R0); 2026 __ mov(locs->out(0).reg(), R0);
2027 compiler->RestoreLiveRegisters(locs); 2027 compiler->RestoreLiveRegisters(locs);
2028 2028
2029 __ b(exit_label()); 2029 __ b(exit_label());
(...skipping 11 matching lines...) Expand all
2041 2041
2042 virtual void EmitNativeCode(FlowGraphCompiler* compiler) { 2042 virtual void EmitNativeCode(FlowGraphCompiler* compiler) {
2043 __ Comment("BoxFloat64x2SlowPath"); 2043 __ Comment("BoxFloat64x2SlowPath");
2044 __ Bind(entry_label()); 2044 __ Bind(entry_label());
2045 const Class& float64x2_class = compiler->float64x2_class(); 2045 const Class& float64x2_class = compiler->float64x2_class();
2046 const Code& stub = 2046 const Code& stub =
2047 Code::Handle(StubCode::GetAllocationStubForClass(float64x2_class)); 2047 Code::Handle(StubCode::GetAllocationStubForClass(float64x2_class));
2048 const ExternalLabel label(stub.EntryPoint()); 2048 const ExternalLabel label(stub.EntryPoint());
2049 2049
2050 LocationSummary* locs = instruction_->locs(); 2050 LocationSummary* locs = instruction_->locs();
2051 locs->live_registers()->Remove(locs->out(0)); 2051 ASSERT(!locs->live_registers()->Contains(locs->out(0)));
2052 2052
2053 compiler->SaveLiveRegisters(locs); 2053 compiler->SaveLiveRegisters(locs);
2054 compiler->GenerateCall(Scanner::kNoSourcePos, // No token position. 2054 compiler->GenerateCall(Scanner::kNoSourcePos, // No token position.
2055 &label, 2055 &label,
2056 RawPcDescriptors::kOther, 2056 RawPcDescriptors::kOther,
2057 locs); 2057 locs);
2058 __ mov(locs->out(0).reg(), R0); 2058 __ mov(locs->out(0).reg(), R0);
2059 compiler->RestoreLiveRegisters(locs); 2059 compiler->RestoreLiveRegisters(locs);
2060 2060
2061 __ b(exit_label()); 2061 __ b(exit_label());
(...skipping 1134 matching lines...) Expand 10 before | Expand all | Expand 10 after
3196 3196
3197 virtual void EmitNativeCode(FlowGraphCompiler* compiler) { 3197 virtual void EmitNativeCode(FlowGraphCompiler* compiler) {
3198 __ Comment("BoxInt32x4SlowPath"); 3198 __ Comment("BoxInt32x4SlowPath");
3199 __ Bind(entry_label()); 3199 __ Bind(entry_label());
3200 const Class& int32x4_class = compiler->int32x4_class(); 3200 const Class& int32x4_class = compiler->int32x4_class();
3201 const Code& stub = 3201 const Code& stub =
3202 Code::Handle(StubCode::GetAllocationStubForClass(int32x4_class)); 3202 Code::Handle(StubCode::GetAllocationStubForClass(int32x4_class));
3203 const ExternalLabel label(stub.EntryPoint()); 3203 const ExternalLabel label(stub.EntryPoint());
3204 3204
3205 LocationSummary* locs = instruction_->locs(); 3205 LocationSummary* locs = instruction_->locs();
3206 locs->live_registers()->Remove(locs->out(0)); 3206 ASSERT(!locs->live_registers()->Contains(locs->out(0)));
3207 3207
3208 compiler->SaveLiveRegisters(locs); 3208 compiler->SaveLiveRegisters(locs);
3209 compiler->GenerateCall(Scanner::kNoSourcePos, // No token position. 3209 compiler->GenerateCall(Scanner::kNoSourcePos, // No token position.
3210 &label, 3210 &label,
3211 RawPcDescriptors::kOther, 3211 RawPcDescriptors::kOther,
3212 locs); 3212 locs);
3213 __ mov(locs->out(0).reg(), R0); 3213 __ mov(locs->out(0).reg(), R0);
3214 compiler->RestoreLiveRegisters(locs); 3214 compiler->RestoreLiveRegisters(locs);
3215 3215
3216 __ b(exit_label()); 3216 __ b(exit_label());
(...skipping 2133 matching lines...) Expand 10 before | Expand all | Expand 10 after
5350 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs()); 5350 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs());
5351 #if defined(DEBUG) 5351 #if defined(DEBUG)
5352 __ LoadImmediate(R4, kInvalidObjectPointer, kNoPP); 5352 __ LoadImmediate(R4, kInvalidObjectPointer, kNoPP);
5353 __ LoadImmediate(R5, kInvalidObjectPointer, kNoPP); 5353 __ LoadImmediate(R5, kInvalidObjectPointer, kNoPP);
5354 #endif 5354 #endif
5355 } 5355 }
5356 5356
5357 } // namespace dart 5357 } // namespace dart
5358 5358
5359 #endif // defined TARGET_ARCH_ARM64 5359 #endif // defined TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698