Issue 367683002: Use JsonMap even for JSON.decode with custom reviver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 367683002: Use JsonMap even for JSON.decode with custom reviver. (Closed)

Created:
6 years, 5 months ago by kasperl

Modified:
6 years, 5 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use JsonMap even for JSON.decode with custom reviver. R=floitsch@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37931

Patch Set 3 : Fix long line in test. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -26 lines)			Patch
M	sdk/lib/_internal/lib/convert_patch.dart	View	1	3 chunks	+22 lines, -24 lines	0 comments	Download
M	tests/corelib/json_map_test.dart	View	1	4 chunks	+23 lines, -1 line	0 comments	Download
M	tests/corelib/map_test.dart	View	1 2	7 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM! https://codereview.chromium.org/367683002/diff/1/tests/corelib/map_test.dart File tests/corelib/map_test.dart (right): https://codereview.chromium.org/367683002/diff/1/tests/corelib/map_test.dart#newcode11 tests/corelib/map_test.dart:11: Map newJsonMapCustomReviver() => JSON.decode('{}', reviver: (key, value) => ...

6 years, 5 months ago (2014-07-01 13:50:58 UTC) #2

kasperl

Committed patchset #3 manually as r37931 (presubmit successful).

6 years, 5 months ago (2014-07-02 06:29:54 UTC) #3

kasperl

6 years, 5 months ago (2014-07-02 06:37:29 UTC) #4

Message was sent while issue was closed.

Turns out that for now I rely on copying the properties over to the new
'processed' object because that doesn't use Object.prototype as it's prototype.
Tests for the win.

Expand Messages | Collapse Messages

Issue 367683002: Use JsonMap even for JSON.decode with custom reviver. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Bug fix. #

Patch Set 3 : Fix long line in test. #

Messages