Use JsonMap even for JSON.decode with custom reviver.

sdk/lib/_internal/lib/convert_patch.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Patch file for dart:convert library.
 
 import 'dart:_js_helper' show patch;
 import 'dart:_foreign_helper' show JS;
 import 'dart:_interceptors' show JSExtendableArray;
 import 'dart:_internal' show MappedIterable;
@@ skipping 34 matching lines @@
     return _convertJsonToDart(parsed, reviver);
   }
 }
 
 /**
  * Walks the raw JavaScript value [json], replacing JavaScript Objects with
  * Maps. [json] is expected to be freshly allocated so elements can be replaced
  * in-place.
  */
 _convertJsonToDart(json, reviver(key, value)) {
-  var revive = reviver == null ? (key, value) => value : reviver;
-
+  assert(reviver != null);
   walk(e) {
     // JavaScript null, string, number, bool are in the correct representation.
     if (JS('bool', '# == null', e) || JS('bool', 'typeof # != "object"', e)) {
       return e;
     }
 
     // This test is needed to avoid identifing '{"__proto__":[]}' as an Array.
     // TODO(sra): Replace this test with cheaper '#.constructor === Array' when
     // bug 621 below is fixed.
     if (JS('bool', 'Object.getPrototypeOf(#) === Array.prototype', e)) {
-      // Teach compiler the type is known by passing it through a JS-expression.
-      var list = JS('JSExtendableArray', '#', e);
       // In-place update of the elements since JS Array is a Dart List.
-      for (int i = 0; i < list.length; i++) {
+      for (int i = 0; i < JS('int', '#.length', e); i++) {
         // Use JS indexing to avoid range checks.  We know this is the only
         // reference to the list, but the compiler will likely never be able to
         // tell that this instance of the list cannot have its length changed by
         // the reviver even though it later will be passed to the reviver at the
         // outer level.
-        var item = JS('', '#[#]', list, i);
-        JS('', '#[#]=#', list, i, revive(i, walk(item)));
+        var item = JS('', '#[#]', e, i);
+        JS('', '#[#]=#', e, i, reviver(i, walk(item)));
       }
-      return list;
+      return e;
     }
 
-    // Otherwise it is a plain Object, so copy to a Map.
-    var keys = JS('JSExtendableArray', 'Object.keys(#)', e);
-    Map map = {};
+    // Otherwise it is a plain object, so copy to a JSON map, so we process
+    // and revive all entries recursively.
+    _JsonMap map = new _JsonMap(e);
+    var processed = map._processed;
+    List<String> keys = map._computeKeys();
     for (int i = 0; i < keys.length; i++) {
       String key = keys[i];
-      map[key] = revive(key, walk(JS('', '#[#]', e, key)));
+      var revived = reviver(key, walk(JS('', '#[#]', e, key)));
+      JS('', '#[#]=#', processed, key, revived);
     }
-    // V8 has a bug with properties named "__proto__"
-    // https://code.google.com/p/v8/issues/detail?id=621
-    var proto = JS('', '#.__proto__', e);
-    // __proto__ can be undefined on IE9.
-    if (JS('bool',
-           'typeof # !== "undefined" && # !== Object.prototype',
-           proto, proto)) {
-      map['__proto__'] = revive('__proto__', walk(proto));
-    }
+
+    // Update the JSON map structure so future access is cheaper.
+    map._original = processed;  // Don't keep two objects around.
     return map;
   }
 
-  return revive(null, walk(json));
+  return reviver(null, walk(json));
 }
 
 _convertJsonToDartLazy(object) {
   // JavaScript null and undefined are represented as null.
   if (object == null) return null;
 
   // JavaScript string, number, bool already has the correct representation.
   if (JS('bool', 'typeof # != "object"', object)) {
     return object;
   }
@@ skipping 60 matching lines @@
 
   Iterable get values {
     if (_isUpgraded) return _upgradedMap.values;
     return new MappedIterable(_computeKeys(), (each) => this[each]);
   }
 
   operator[]=(key, value) {
     if (_isUpgraded) {
       _upgradedMap[key] = value;
     } else if (containsKey(key)) {
-      _setProperty(_processed, key, value);
-      _setProperty(_original, key, null);  // Reclaim memory.
+      var processed = _processed;
+      _setProperty(processed, key, value);
+      var original = _original;
+      if (!identical(original, processed)) {
+        _setProperty(original, key, null);  // Reclaim memory.
+      }
     } else {
       _upgrade()[key] = value;
     }
   }
 
   void addAll(Map other) {
     other.forEach((key, value) {
       this[key] = value;
     });
   }
@@ skipping 142 matching lines @@
   static _newJavaScriptObject()
       => JS('=Object', 'Object.create(null)');
 }
 
 @patch
 class _Utf8Encoder {
   // Use Uint8List when supported on all platforms.
   @patch
   static List<int> _createBuffer(int size) => new List<int>(size);
 }