Don't consider controller.addError to be a zone-crossing.

Don't consider controller.addError to be a zone-crossing.

BUG= http://dartbug.com/18776
R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38120

[floitsch, 2014-07-02 14:42:27]

RFC.
Test 27 doesn't work yet.
Please try, by hand, to figure out what the result should be.

[Lasse Reichstein Nielsen, 2014-07-03 12:43:41]

lgtm

[floitsch, 2014-07-03 17:29:26]

PTAL. especially the new test.

[Lasse Reichstein Nielsen, 2014-07-10 09:45:17]

LGTM

https://codereview.chromium.org/366813005/diff/40001/tests/lib/async/catch_er...
File tests/lib/async/catch_errors27_test.dart (right):

https://codereview.chromium.org/366813005/diff/40001/tests/lib/async/catch_er...
tests/lib/async/catch_errors27_test.dart:40: events.add(x);
Consider putting a prefix on the event here, like "foo $x".

https://codereview.chromium.org/366813005/diff/40001/tests/lib/async/catch_er...
tests/lib/async/catch_errors27_test.dart:46: onDone: () {
Expect.fail("Unexpected callback"); });
This is darn nigh unreadable. Is there any way to make it easier to grok? Maybe
some judiciously inserted empty lines?
Maybe name the streams returned by catchErrors (outerErrors/innerErrors)?

https://codereview.chromium.org/366813005/diff/40001/tests/lib/async/catch_er...
tests/lib/async/catch_errors27_test.dart:52: "stream 101",
Unindent (deindent? exdent?) by 1.

https://codereview.chromium.org/366813005/diff/40001/tests/lib/async/stream_z...
File tests/lib/async/stream_zones_test.dart (right):

https://codereview.chromium.org/366813005/diff/40001/tests/lib/async/stream_z...
tests/lib/async/stream_zones_test.dart:120: 
All the tests have nested zones. How about independent zones:

  var c;
  runZoned(() { c = new StreamController(); ... });
  runZoned(() { c.add(...)...});

?

[floitsch, 2014-07-10 13:50:42]

https://codereview.chromium.org/366813005/diff/40001/tests/lib/async/catch_er...
File tests/lib/async/catch_errors27_test.dart (right):

https://codereview.chromium.org/366813005/diff/40001/tests/lib/async/catch_er...
tests/lib/async/catch_errors27_test.dart:40: events.add(x);
On 2014/07/10 09:45:17, Lasse Reichstein Nielsen wrote:
> Consider putting a prefix on the event here, like "foo $x".

Done.

https://codereview.chromium.org/366813005/diff/40001/tests/lib/async/catch_er...
tests/lib/async/catch_errors27_test.dart:46: onDone: () {
Expect.fail("Unexpected callback"); });
On 2014/07/10 09:45:17, Lasse Reichstein Nielsen wrote:
> This is darn nigh unreadable. Is there any way to make it easier to grok?
Maybe
> some judiciously inserted empty lines?
> Maybe name the streams returned by catchErrors (outerErrors/innerErrors)?

Should be better now.

https://codereview.chromium.org/366813005/diff/40001/tests/lib/async/catch_er...
tests/lib/async/catch_errors27_test.dart:52: "stream 101",
On 2014/07/10 09:45:17, Lasse Reichstein Nielsen wrote:
> Unindent (deindent? exdent?) by 1.

Done.

https://codereview.chromium.org/366813005/diff/40001/tests/lib/async/stream_z...
File tests/lib/async/stream_zones_test.dart (right):

https://codereview.chromium.org/366813005/diff/40001/tests/lib/async/stream_z...
tests/lib/async/stream_zones_test.dart:120: 
On 2014/07/10 09:45:17, Lasse Reichstein Nielsen wrote:
> All the tests have nested zones. How about independent zones:
> 
>   var c;
>   runZoned(() { c = new StreamController(); ... });
>   runZoned(() { c.add(...)...});
> 
> ?

Done.

[floitsch, 2014-07-10 13:52:38]

Committed patchset #5 manually as r38120 (presubmit successful).