Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 366463002: Change Maps to HashMaps to save in performance, index and generated directories not touched (Closed)

Created:
6 years, 5 months ago by jwren
Modified:
6 years, 5 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change Maps to HashMaps to save in performance, index and generated directories not touched R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=37840

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -60 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 9 chunks +9 lines, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_highlights.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_navigation.dart View 3 chunks +6 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_outline.dart View 4 chunks +7 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/element.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/context_directory_manager.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/package_map_provider.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/package_uri_resolver.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 15 chunks +20 lines, -20 lines 0 comments Download
M pkg/analysis_server/lib/src/resource.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/package_uri_resolver_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jwren
6 years, 5 months ago (2014-06-30 22:29:36 UTC) #1
Paul Berry
lgtm
6 years, 5 months ago (2014-06-30 22:34:11 UTC) #2
jwren
6 years, 5 months ago (2014-06-30 22:40:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37840 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698