pkg/analysis_server/lib/src/computer/element.dart - Issue 366463002: Change Maps to HashMaps to save in performance, index and generated directories not touched

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/computer/element.dart

Issue 366463002: Change Maps to HashMaps to save in performance, index and generated directories not touched (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/computer/computer_outline.dart ('k') | pkg/analysis_server/lib/src/context_directory_manager.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/computer/element.dart

diff --git a/pkg/analysis_server/lib/src/computer/element.dart b/pkg/analysis_server/lib/src/computer/element.dart

index 9b23a7504779d4f58194d7d06f9011f1d89ccb6a..3be6112642d5b08d3e9c248763f053497d7d0e1d 100644

--- a/pkg/analysis_server/lib/src/computer/element.dart

+++ b/pkg/analysis_server/lib/src/computer/element.dart

@@ -4,6 +4,8 @@

library computer.element;

+import 'dart:collection';

import 'package:analysis_server/src/constants.dart';

import 'package:analyzer/src/generated/element.dart' as engine;

import 'package:analyzer/src/generated/utilities_dart.dart' as engine;

@@ -79,7 +81,7 @@ class Element {

isStatic: _isStatic(element));

}

- factory Element.fromJson(Map<String, Object> map) {

+ factory Element.fromJson(HashMap<String, Object> map) {

ElementKind kind = ElementKind.valueOf(map[KIND]);

int flags = map[FLAGS];

return new Element(kind, map[NAME], map[OFFSET], map[LENGTH], _hasFlag(

@@ -100,8 +102,8 @@ class Element {

return flags;

}

- Map<String, Object> toJson() {

- Map<String, Object> json = {

+ HashMap<String, Object> toJson() {

+ HashMap<String, Object> json = {

KIND: kind.name,

NAME: name,

OFFSET: offset,