Validate headers when added to HttpHeaders.

Validate headers when added to HttpHeaders.

BUG=
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38009

[Søren Gjesse, 2014-07-04 09:24:54]

lgtm

https://codereview.chromium.org/364313002/diff/1/sdk/lib/io/http_headers.dart
File sdk/lib/io/http_headers.dart (right):

https://codereview.chromium.org/364313002/diff/1/sdk/lib/io/http_headers.dart...
sdk/lib/io/http_headers.dart:48: void _addAll(String name, value) {
Add

assert(name == _validateField(name));

here as well.

https://codereview.chromium.org/364313002/diff/1/sdk/lib/io/http_headers.dart...
sdk/lib/io/http_headers.dart:49: if (value is List) {
Btw. shouldn't this be just Iterable?

https://codereview.chromium.org/364313002/diff/1/sdk/lib/io/http_headers.dart...
sdk/lib/io/http_headers.dart:573: "Invalid HTTP header field:
${JSON.encode(field)}");
Lets be precise: field -> field name

https://codereview.chromium.org/364313002/diff/1/sdk/lib/io/http_headers.dart...
sdk/lib/io/http_headers.dart:584: "Invalid HTTP header value:
${JSON.encode(value)}");
value -> field value

https://codereview.chromium.org/364313002/diff/1/tests/standalone/io/http_hea...
File tests/standalone/io/http_headers_test.dart (right):

https://codereview.chromium.org/364313002/diff/1/tests/standalone/io/http_hea...
tests/standalone/io/http_headers_test.dart:465: void testInvalidField() {
testInvalidField -> testInvalidFieldName

https://codereview.chromium.org/364313002/diff/1/tests/standalone/io/http_hea...
tests/standalone/io/http_headers_test.dart:483: void testInvalidValue() {
testInvalidValue -> testInvalidFieldValue

[Anders Johnsen, 2014-07-04 11:03:50]

https://codereview.chromium.org/364313002/diff/1/sdk/lib/io/http_headers.dart
File sdk/lib/io/http_headers.dart (right):

https://codereview.chromium.org/364313002/diff/1/sdk/lib/io/http_headers.dart...
sdk/lib/io/http_headers.dart:48: void _addAll(String name, value) {
On 2014/07/04 09:24:54, Søren Gjesse wrote:
> Add
> 
> assert(name == _validateField(name));
> 
> here as well.

Done.

https://codereview.chromium.org/364313002/diff/1/sdk/lib/io/http_headers.dart...
sdk/lib/io/http_headers.dart:49: if (value is List) {
On 2014/07/04 09:24:54, Søren Gjesse wrote:
> Btw. shouldn't this be just Iterable?

Yeah.

https://codereview.chromium.org/364313002/diff/1/sdk/lib/io/http_headers.dart...
sdk/lib/io/http_headers.dart:573: "Invalid HTTP header field:
${JSON.encode(field)}");
On 2014/07/04 09:24:54, Søren Gjesse wrote:
> Lets be precise: field -> field name

Done.

https://codereview.chromium.org/364313002/diff/1/sdk/lib/io/http_headers.dart...
sdk/lib/io/http_headers.dart:584: "Invalid HTTP header value:
${JSON.encode(value)}");
On 2014/07/04 09:24:54, Søren Gjesse wrote:
> value -> field value

Done.

https://codereview.chromium.org/364313002/diff/1/tests/standalone/io/http_hea...
File tests/standalone/io/http_headers_test.dart (right):

https://codereview.chromium.org/364313002/diff/1/tests/standalone/io/http_hea...
tests/standalone/io/http_headers_test.dart:465: void testInvalidField() {
On 2014/07/04 09:24:54, Søren Gjesse wrote:
> testInvalidField -> testInvalidFieldName

Done.

https://codereview.chromium.org/364313002/diff/1/tests/standalone/io/http_hea...
tests/standalone/io/http_headers_test.dart:483: void testInvalidValue() {
On 2014/07/04 09:24:54, Søren Gjesse wrote:
> testInvalidValue -> testInvalidFieldValue

Done.

[Anders Johnsen, 2014-07-04 11:04:14]

Committed patchset #2 manually as r38009 (presubmit successful).