Validate headers when added to HttpHeaders.

tests/standalone/io/http_headers_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart.io;
 
 import "package:expect/expect.dart";
 import "dart:async";
 import "dart:collection";
 import "dart:convert";
@@ skipping 444 matching lines @@
                 headers._parseCookies().single.value);
 }
 
 void testHeaderLists() {
   HttpHeaders.GENERAL_HEADERS.forEach((x) => null);
   HttpHeaders.ENTITY_HEADERS.forEach((x) => null);
   HttpHeaders.RESPONSE_HEADERS.forEach((x) => null);
   HttpHeaders.REQUEST_HEADERS.forEach((x) => null);
 }
 
+void testInvalidFieldName() {
+  void test(String field) {
+    _HttpHeaders headers = new _HttpHeaders("1.1");
+    Expect.throws(() => headers.add(field, "value"),
+                  (e) => e is FormatException);
+    Expect.throws(() => headers.set(field, "value"),
+                  (e) => e is FormatException);
+    Expect.throws(() => headers.remove(field, "value"),
+                  (e) => e is FormatException);
+    Expect.throws(() => headers.removeAll(field),
+                  (e) => e is FormatException);
+  }
+  test('\r');
+  test('\n');
+  test(',');
+  test('test\x00');
+}
+
+void testInvalidFieldValue() {
+  void test(value, {bool remove: true}) {
+    _HttpHeaders headers = new _HttpHeaders("1.1");
+    Expect.throws(() => headers.add("field", value),
+                  (e) => e is FormatException);
+    Expect.throws(() => headers.set("field", value),
+                  (e) => e is FormatException);
+    if (remove) {
+      Expect.throws(() => headers.remove("field", value),
+                    (e) => e is FormatException);
+    }
+  }
+  test('\r');
+  test('\n');
+  test('test\x00');
+  // Test we handle other types correctly.
+  test(new StringBuffer('\x00'), remove: false);
+}
+
 main() {
   testMultiValue();
   testDate();
   testExpires();
   testIfModifiedSince();
   testHost();
   testEnumeration();
   testHeaderValue();
   testContentType();
   testContentTypeCache();
   testCookie();
   testInvalidCookie();
   testHeaderLists();
+  testInvalidFieldName();
+  testInvalidFieldValue();
 }