Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 357563002: Fix pub run tests on Windows. (Closed)

Created:
6 years, 6 months ago by Bob Nystrom
Modified:
6 years, 6 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change prefix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M sdk/lib/_internal/pub/test/run/nonexistent_script_in_dependency_test.dart View 1 2 chunks +4 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/run/nonexistent_script_test.dart View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
6 years, 6 months ago (2014-06-24 22:10:02 UTC) #1
nweiz
lgtm https://codereview.chromium.org/357563002/diff/1/sdk/lib/_internal/pub/test/run/nonexistent_script_in_dependency_test.dart File sdk/lib/_internal/pub/test/run/nonexistent_script_in_dependency_test.dart (right): https://codereview.chromium.org/357563002/diff/1/sdk/lib/_internal/pub/test/run/nonexistent_script_in_dependency_test.dart#newcode5 sdk/lib/_internal/pub/test/run/nonexistent_script_in_dependency_test.dart:5: import 'package:path/path.dart' as path; Nit: I think we ...
6 years, 6 months ago (2014-06-24 23:00:27 UTC) #2
Bob Nystrom
https://codereview.chromium.org/357563002/diff/1/sdk/lib/_internal/pub/test/run/nonexistent_script_in_dependency_test.dart File sdk/lib/_internal/pub/test/run/nonexistent_script_in_dependency_test.dart (right): https://codereview.chromium.org/357563002/diff/1/sdk/lib/_internal/pub/test/run/nonexistent_script_in_dependency_test.dart#newcode5 sdk/lib/_internal/pub/test/run/nonexistent_script_in_dependency_test.dart:5: import 'package:path/path.dart' as path; On 2014/06/24 23:00:27, nweiz wrote: ...
6 years, 6 months ago (2014-06-25 20:28:42 UTC) #3
Bob Nystrom
6 years, 6 months ago (2014-06-25 20:29:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r37705 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698