Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 35663003: Companion CL to support $0, $1, $2 (Closed)

Created:
7 years, 2 months ago by Jacob
Modified:
7 years, 1 month ago
Reviewers:
justinfagnani, blois
CC:
reviews_dartlang.org, vsm
Visibility:
Public.

Description

Companion CL to support $0, $1, $2 BUG= R=justinfagnani@google.com Committed: https://code.google.com/p/dart/source/detail?r=29112

Patch Set 1 : patch set take 2 #

Total comments: 4

Patch Set 2 : PTAL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M sdk/lib/js/dartium/js_dartium.dart View 1 1 chunk +30 lines, -0 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Jacob
Companion CL for https://codereview.chromium.org/28763006
7 years, 2 months ago (2013-10-22 23:42:42 UTC) #1
justinfagnani
On 2013/10/22 23:42:42, Jacob wrote: > Companion CL for https://codereview.chromium.org/28763006 Something's messed up with this ...
7 years, 2 months ago (2013-10-23 00:50:26 UTC) #2
justinfagnani
lgtm https://codereview.chromium.org/35663003/diff/90001/sdk/lib/js/dartium/js_dartium.dart File sdk/lib/js/dartium/js_dartium.dart (right): https://codereview.chromium.org/35663003/diff/90001/sdk/lib/js/dartium/js_dartium.dart#newcode133 sdk/lib/js/dartium/js_dartium.dart:133: List _stripUndefinedArgs(List args) { this could be: args.takeWhile((i) ...
7 years, 2 months ago (2013-10-23 00:54:03 UTC) #3
Jacob
https://codereview.chromium.org/35663003/diff/90001/sdk/lib/js/dartium/js_dartium.dart File sdk/lib/js/dartium/js_dartium.dart (right): https://codereview.chromium.org/35663003/diff/90001/sdk/lib/js/dartium/js_dartium.dart#newcode133 sdk/lib/js/dartium/js_dartium.dart:133: List _stripUndefinedArgs(List args) { On 2013/10/23 00:54:03, justinfagnani wrote: ...
7 years, 2 months ago (2013-10-23 01:26:13 UTC) #4
Jacob
7 years, 1 month ago (2013-10-23 19:32:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r29112 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698