Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 28763006: Support $0, $1, ... $6, inspect, and other console api methods. (Closed)

Created:
7 years, 2 months ago by Jacob
Modified:
7 years, 2 months ago
Reviewers:
justinfagnani, blois
CC:
reviews+dom_dartlang.org, vsm
Visibility:
Public.

Description

Support $0, $1, ... $6, inspect, and other console api methods. This fixes https://code.google.com/p/dart/issues/detail?id=10502 BUG= R=blois@google.com Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=1469

Patch Set 1 #

Patch Set 2 : ready for review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -5 lines) Patch
LayoutTests/dart/inspector/debugger-eval-on-call-frame.html View 1 chunk +11 lines, -0 lines 0 comments Download
LayoutTests/dart/inspector/debugger-eval-on-call-frame-expected.txt View 2 chunks +11 lines, -0 lines 0 comments Download
Source/bindings/dart/DartHandleProxy.cpp View 1 3 chunks +50 lines, -3 lines 0 comments Download
Source/bindings/dart/DartJsInterop.cpp View 5 chunks +63 lines, -1 line 0 comments Download
Source/bindings/dart/DartUtilities.h View 1 chunk +1 line, -0 lines 0 comments Download
Source/bindings/dart/DartUtilities.cpp View 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jacob
Companion CL for https://codereview.chromium.org/35663003/
7 years, 2 months ago (2013-10-22 23:43:20 UTC) #1
blois
lgtm
7 years, 2 months ago (2013-10-23 00:01:56 UTC) #2
Jacob
7 years, 2 months ago (2013-10-23 19:40:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r1469 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698