Issue 354663008: Clean up pub's exceptions.

Issue 354663008: Clean up pub's exceptions. (Closed)

Created:
6 years, 6 months ago by nweiz

Modified:
6 years, 6 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Clean up pub's exceptions. This change does three things: * Splits out a WrappedException class from ApplicationException. * Uses fail() pervasively rather than new ApplicationException() everywhere. * Moves exception classes from utils.dart to exceptions.dart. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=37713

Patch Set 1 #

Total comments: 4

Patch Set 2 : code review #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -120 lines)			Patch
M	sdk/lib/_internal/pub/bin/pub.dart	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/cycle_exception.dart	View		2 chunks	+1 line, -6 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/command.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/command/cache_add.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/command/lish.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A	sdk/lib/_internal/pub/lib/src/exceptions.dart	View	1	1 chunk	+105 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/git.dart	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/pubspec.dart	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/solver/version_solver.dart	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/source/git.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/source/hosted.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/source/path.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/utils.dart	View		2 chunks	+5 lines, -95 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/transformers_needed_by_transformers/error_test.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Couple of nits bug LGTM! https://codereview.chromium.org/354663008/diff/1/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart File sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart (right): https://codereview.chromium.org/354663008/diff/1/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart#newcode223 sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart:223: fail("$message were defined in ...

6 years, 6 months ago (2014-06-25 19:44:10 UTC) #2

nweiz

https://codereview.chromium.org/354663008/diff/1/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart File sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart (right): https://codereview.chromium.org/354663008/diff/1/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart#newcode223 sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart:223: fail("$message were defined in $location,\n" On 2014/06/25 19:44:10, Bob ...

6 years, 6 months ago (2014-06-25 23:26:46 UTC) #3

nweiz

6 years, 6 months ago (2014-06-25 23:29:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r37713 (presubmit successful).

Expand Messages | Collapse Messages