Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: sdk/lib/_internal/pub/lib/src/git.dart

Issue 354663008: Clean up pub's exceptions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/exceptions.dart ('k') | sdk/lib/_internal/pub/lib/src/pubspec.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/git.dart
diff --git a/sdk/lib/_internal/pub/lib/src/git.dart b/sdk/lib/_internal/pub/lib/src/git.dart
index 5ba66b2ab4f3528044465bdb218f4f4cead9b989..598627aece689e5594009695f88573b846298af6 100644
--- a/sdk/lib/_internal/pub/lib/src/git.dart
+++ b/sdk/lib/_internal/pub/lib/src/git.dart
@@ -45,8 +45,7 @@ bool _isInstalledCache;
Future<List<String>> run(List<String> args,
{String workingDir, Map<String, String> environment}) {
if (!isInstalled) {
- throw new ApplicationException(
- "Cannot find a Git executable.\n"
+ fail("Cannot find a Git executable.\n"
"Please ensure Git is correctly installed.");
}
@@ -61,8 +60,7 @@ Future<List<String>> run(List<String> args,
List<String> runSync(List<String> args, {String workingDir,
Map<String, String> environment}) {
if (!isInstalled) {
- throw new ApplicationException(
- "Cannot find a Git executable.\n"
+ fail("Cannot find a Git executable.\n"
"Please ensure Git is correctly installed.");
}
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/exceptions.dart ('k') | sdk/lib/_internal/pub/lib/src/pubspec.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698